From: Andrew Morton <akpm@osdl.org>
To: Peter Osterlund <petero2@telia.com>
Cc: axboe@suse.de, piggin@cyberone.com.au, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test8, DEBUG_SLAB, oops in as_latter_request()
Date: Sun, 19 Oct 2003 14:20:42 -0700 [thread overview]
Message-ID: <20031019142042.2f41eb68.akpm@osdl.org> (raw)
In-Reply-To: <m2ismlovep.fsf@p4.localdomain>
Peter Osterlund <petero2@telia.com> wrote:
>
> I was running 2.6.0-test8 compiled with CONFIG_DEBUG_SLAB=y. When
> testing the CDRW packet writing driver, I got an oops in
> as_latter_request. (Full oops at the end of this message.) It is
> repeatable and happens because arq->rb_node.rb_right is uninitialized.
deadline seems to have the same problem.
We may as well squish this with the big hammer?
drivers/block/as-iosched.c | 1 +
drivers/block/deadline-iosched.c | 1 +
2 files changed, 2 insertions(+)
diff -puN drivers/block/as-iosched.c~iosched-oops-fixes drivers/block/as-iosched.c
--- 25/drivers/block/as-iosched.c~iosched-oops-fixes 2003-10-19 14:17:39.000000000 -0700
+++ 25-akpm/drivers/block/as-iosched.c 2003-10-19 14:18:09.000000000 -0700
@@ -1718,6 +1718,7 @@ static int as_set_request(request_queue_
struct as_rq *arq = mempool_alloc(ad->arq_pool, gfp_mask);
if (arq) {
+ memset(arq, 0, sizeof(*arq));
RB_CLEAR(&arq->rb_node);
arq->request = rq;
arq->state = AS_RQ_NEW;
diff -puN drivers/block/deadline-iosched.c~iosched-oops-fixes drivers/block/deadline-iosched.c
--- 25/drivers/block/deadline-iosched.c~iosched-oops-fixes 2003-10-19 14:17:39.000000000 -0700
+++ 25-akpm/drivers/block/deadline-iosched.c 2003-10-19 14:17:39.000000000 -0700
@@ -775,6 +775,7 @@ deadline_set_request(request_queue_t *q,
drq = mempool_alloc(dd->drq_pool, gfp_mask);
if (drq) {
+ memset(drq, 0, sizeof(*drq));
RB_CLEAR(&drq->rb_node);
drq->request = rq;
_
next prev parent reply other threads:[~2003-10-19 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-19 19:54 2.6.0-test8, DEBUG_SLAB, oops in as_latter_request() Peter Osterlund
2003-10-19 21:20 ` Andrew Morton [this message]
2003-10-20 0:25 ` Nick Piggin
2003-10-20 7:09 ` Jens Axboe
2003-10-20 8:08 ` Nick Piggin
2003-10-20 19:37 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031019142042.2f41eb68.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox