From: Christoph Hellwig <hch@infradead.org>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
Mike Christie <mikenc@us.ibm.com>
Subject: Re: [patch] qlogic_cs: init legacy_hosts
Date: Tue, 21 Oct 2003 10:57:57 +0100 [thread overview]
Message-ID: <20031021105757.A24895@infradead.org> (raw)
In-Reply-To: <20031021092858.GA8632@cathedrallabs.org>; from aris@cathedrallabs.org on Tue, Oct 21, 2003 at 07:28:58AM -0200
On Tue, Oct 21, 2003 at 07:28:58AM -0200, Aristeu Sergio Rozanski Filho wrote:
> hi Christoph,
> > > @@ -249,6 +249,8 @@
> > > else
> > > qlogicfas_preset(link->io.BasePort1, link->irq.AssignedIRQ);
> > >
> > > + INIT_LIST_HEAD(&qlogicfas_driver_template.legacy_hosts);
> > > +
> >
> > qlogic_cs is a newstyle driver, no need to initialize it.
> then it needs more work. without initializing it i get an oops in
> scsi_register(). i guess the qlogic_cs is an oldstyle driver by now
> because it uses qlogicfas template and functions.
why do you call scsi_register at all? You need to uses scsi_host_alloc in
the pcmcia case.
next prev parent reply other threads:[~2003-10-21 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 23:25 [patch] qlogic_cs: init legacy_hosts Aristeu Sergio Rozanski Filho
2003-10-21 8:11 ` Christoph Hellwig
2003-10-21 9:28 ` Aristeu Sergio Rozanski Filho
2003-10-21 9:57 ` Christoph Hellwig [this message]
2003-10-21 10:06 ` Aristeu Sergio Rozanski Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031021105757.A24895@infradead.org \
--to=hch@infradead.org \
--cc=aris@cathedrallabs.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikenc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox