Re: [PATCH] you have how many nodes??

[jbarnes@sgi.com (Jesse Barnes)]

I just tried -test8-mm1 on a 256p/128 node machine and these changes
almost work.  I still needed to change ZONE_SHIFT from BITS_PER_LONG - 8
to BITS_PER_LONG - 10 because of the way set_page_zone() is called from
memmap_init_zone() (set_page_zone(page, nid * MAX_NR_ZONES + zone);).
So shouldn't ZONE_SHIFT be BITS_PER_LONG -  NODES_SHIFT or something?

Jesse

On Fri, Sep 19, 2003 at 03:01:46PM -0700, Matthew Dobson wrote:
> Andrew,
> 	Here's a small update to the numnodes fix that went into -mm3.  The 
> biggest changes are:
> 	1) move the actual NODES_SHIFT and MAX_NUMNODES definitions into 
> linux/numa.h and include this in linux/mmzone.h, instead of being 
> directly in linux/mmzone.h.  This allows other files to include *just* 
> the NUMNODES stuff w/out grabbing all of mmzone.h.
> 	2) pull NODE_SHIFT out of linux/mm.h.  This isn't used anywhere in 
> 	the kernel, and it will only get confused with NODES_SHIFT.
> 	3) Fix the IA64 patch.  The original patch I had sent out hadn't 
> 	been tested on IA64.  It was mostly right, but there were circular 
> dependencies.  All better now, and acked by Jesse.
> 	4) In linux/mmzone.h, insert code to define MAX_NODES_SHIFT based on 
> the size of unsigned long.  For 64-bit arches, we can have a much larger 
> value.  This allows IA64 to have 100's or 1000's of nodes. 
> MAX_NODES_SHIFT is defined as 10 (ie: 1024 nodes) for 64-bit for now, 
> although it could likely be much larger.  For 32-bit it is 6 (ie: 64 nodes).
> 	5) Small cleanup in include/asm-arm/memory.h.  Mostly the result of 
> 	the new linux/numa.h file.  Much cleaner and more readable now.
> 
> Russell, if you get a chance, I'd really appreciate a sanity check on 
> the arm code.  It really hasn't been tested, but the changes are pretty 
> small.