From: Christoph Hellwig <hch@infradead.org>
To: Pat Gefre <pfg@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Altix console driver
Date: Wed, 22 Oct 2003 15:51:37 +0100 [thread overview]
Message-ID: <20031022155137.A23053@infradead.org> (raw)
In-Reply-To: <Pine.SGI.3.96.1031022093244.262870B-100000@fsgi900.americas.sgi.com>; from pfg@sgi.com on Wed, Oct 22, 2003 at 09:39:12AM -0500
On Wed, Oct 22, 2003 at 09:39:12AM -0500, Pat Gefre wrote:
> + > Were all the points which Christoph raised considered?
> +
> + No.
> +
>
> Which item(s), specifically, do you have an issue with ?
You're still registering with the normal serial major/minor without
using serial core. That means the normal serial driver can't be used
when sn_serial is loaded, e.g. for using a pci serial card in an
altix. The irq mess still isn't fixed - this isn't exactly an issue
with this driver but I exposing the bloody mess outside arch/ia64/sn
is a very bad idea. I'd suggest kicking ajm to fix that up.
pciio.h has no business beeing included in this driver that doesn't
use anything PCIish, again a core SN issue that needs fixing.
Also after reading through the new comment ontop of the file it might
be a good idea to rename it to sn_console.c, especially now that there
is a real ioc4 serial driver.
next prev parent reply other threads:[~2003-10-22 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-21 21:26 [PATCH] Altix console driver Patrick Gefre
2003-10-21 22:00 ` Andrew Morton
2003-10-21 22:47 ` Pat Gefre
2003-10-22 14:07 ` Christoph Hellwig
2003-10-22 14:39 ` Pat Gefre
2003-10-22 14:51 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-09-17 22:24 Jesse Barnes
2003-09-17 22:21 ` Andrew Morton
2003-09-17 22:55 ` Jesse Barnes
2003-09-18 7:05 ` Christoph Hellwig
2003-09-18 12:09 ` Alan Cox
2003-09-19 15:21 ` Jesse Barnes
2003-09-19 15:33 ` Alan Cox
2003-09-20 19:24 ` Jamie Lokier
2003-09-20 22:44 ` Alan Cox
[not found] ` <mailman.1063838640.11239.linux-kernel2news@redhat.com>
2003-09-17 23:45 ` Pete Zaitcev
2003-09-18 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031022155137.A23053@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox