* Kill unneccessary debug printk
@ 2003-10-20 17:07 Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2003-10-20 17:07 UTC (permalink / raw)
To: Rusty trivial patch monkey Russell, kernel list
Hi!
This printk is unneccessary for quite a long time, please kill it. [I
added it, so it should be okay for me to request it being killed..]
Pavel
iIndex: arch/i386/kernel/setup.c
===================================================================
RCS file: /home/pavel/sf/bitbucket/bkcvs/linux-2.5/arch/i386/kernel/setup.c,v
retrieving revision 1.100
diff -u -r1.100 setup.c
--- clean/arch/i386/kernel/setup.c 1 Oct 2003 17:30:14 -0000 1.100
+++ linux/arch/i386/kernel/setup.c 20 Oct 2003 16:57:58 -0000
@@ -964,7 +964,6 @@
apm_info.bios = APM_BIOS_INFO;
ist_info = IST_INFO;
saved_videomode = VIDEO_MODE;
- printk("Video mode to be used for restore is %lx\n", saved_videomode);
if( SYS_DESC_TABLE.length != 0 ) {
MCA_bus = SYS_DESC_TABLE.table[3] &0x2;
machine_id = SYS_DESC_TABLE.table[0];
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] 5+ messages in thread
* re: Kill unneccessary debug printk
@ 2003-10-20 18:05 John Mock
2003-10-23 20:00 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: John Mock @ 2003-10-20 18:05 UTC (permalink / raw)
To: linux-kernel
Actually, that 'printk' is useful. As i understand it, the only way software
suspend is going to work is that if the same video mode is used on resume as
on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate
a proper string for 'lilo -R' (which i already do to make sure the correct
kernel gets resumed during testing). If i'm mistaken about needing to set
VGA mode identically on resume, then i have no objection to removing the
printk.
I'm also fine with flushing it that if there's another reasonably convenient
way of obtaining the same information.
-- JM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kill unneccessary debug printk
2003-10-20 18:05 Kill unneccessary debug printk John Mock
@ 2003-10-23 20:00 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2003-10-23 20:00 UTC (permalink / raw)
To: John Mock; +Cc: linux-kernel
Hi!
> Actually, that 'printk' is useful. As i understand it, the only way software
> suspend is going to work is that if the same video mode is used on resume as
> on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate
> a proper string for 'lilo -R' (which i already do to make sure the correct
> kernel gets resumed during testing). If i'm mistaken about needing to set
> VGA mode identically on resume, then i have no objection to removing the
> printk.
Oops, someone is using my debug printk :-(. I'll at least try
to merge it with some other msg, so it does not waste full
line.
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kill unneccessary debug printk
@ 2003-10-23 21:42 John Mock
2003-10-23 23:34 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: John Mock @ 2003-10-23 21:42 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-kernel
> Actually, that 'printk' is useful. As i understand it, the only way software
> suspend is going to work is that if the same video mode is used on resume as
> on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate
> a proper string for 'lilo -R' (which i already do to make sure the correct
> kernel gets resumed during testing). If i'm mistaken about needing to set
> VGA mode identically on resume, then i have no objection to removing the
> printk.
Oops, someone is using my debug printk :-(. I'll at least try
to merge it with some other msg, so it does not waste full
line.
Better yet, let's take this opportunity to do this more cleanly. How
about having something like /sys/power/vmode (or /proc/...) contain that
inforemation instead? With luck, it might even be few kernel bytes than
the original printk (or at least not much more). (I know nothing about
either /proc or /sys, so it would take me awhile to suggest a patch).
Thanks for the kind response.
-- JM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kill unneccessary debug printk
2003-10-23 21:42 John Mock
@ 2003-10-23 23:34 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2003-10-23 23:34 UTC (permalink / raw)
To: John Mock; +Cc: linux-kernel
Hi!
> > Actually, that 'printk' is useful. As i understand it, the only way software
> > suspend is going to work is that if the same video mode is used on resume as
> > on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate
> > a proper string for 'lilo -R' (which i already do to make sure the correct
> > kernel gets resumed during testing). If i'm mistaken about needing to set
> > VGA mode identically on resume, then i have no objection to removing the
> > printk.
>
> Oops, someone is using my debug printk :-(. I'll at least try
> to merge it with some other msg, so it does not waste full
> line.
>
> Better yet, let's take this opportunity to do this more cleanly. How
> about having something like /sys/power/vmode (or /proc/...) contain that
> inforemation instead? With luck, it might even be few kernel bytes than
> the original printk (or at least not much more). (I know nothing about
> either /proc or /sys, so it would take me awhile to suggest a patch).
Well, you probably know about as much as I do. I'm afraid I'm just
going to take the easy way out.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-23 23:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-20 18:05 Kill unneccessary debug printk John Mock
2003-10-23 20:00 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2003-10-23 21:42 John Mock
2003-10-23 23:34 ` Pavel Machek
2003-10-20 17:07 Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).