Re: [PATCH] NLS as module

["Randy.Dunlap" <rddunlap@osdl.org>]

On Sun, 26 Oct 2003 00:55:18 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:

| On Sat, 25 Oct 2003, OGAWA Hirofumi wrote:
| 
| > Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
| >
| > > Problem: NLS support can only be compiled in the kernel - and not as a
| > > module. And if you don't configure one of Joliet / FAT and some other
| > > filesystems at kernel compile-time, you can't compile these filesystems
| > > later as modules(*). However, I see nothing that would prevent one from
| > > compiling nls_base as a module. I tried - it worked, but I didn't actually
| > > use any of the codepages. Just tried insmod nls_base, insmod <fs>, mount.
| > > So, is it desired / really this trivial or are there some real reasons why
| > > nls_base cannot be properly done as a module? I am attaching a naive
| > > patch - but not really understanding NLS internals and not being able to
| > > extensively test it, it might be not quite correct.
| >
| > Sound good to me. And I like this, but it may be more test needed
| > (i.e. module autoload etc.). So I suggest it start on development
| > tree. And backport after it.
| 
| Sure. Attached is a patch against 2.6.0-test7. Looks like it's not going
| to make it into 2.6.0, but, maybe later. And I reversed the dependencies -
| looks more logical, that FAT, SMB, etc. depend on NLS, and not vise versa.
| I tested it briefly, seems to work.

I would prefer to see the opposite:  selecting an FS that requires NLS
should force NLS to be enabled, via "select NLS".
For example:


| diff -ur linux-2.6.0-test7/fs/Kconfig linux-2.6.0-test7.new/fs/Kconfig
| --- linux-2.6.0-test7/fs/Kconfig	Thu Oct  9 22:11:31 2003
| +++ linux-2.6.0-test7.new/fs/Kconfig	Sat Oct 25 21:24:13 2003
| @@ -246,6 +246,7 @@
| 
|  config JFS_FS
|  	tristate "JFS filesystem support"
| -	depends on NLS
	select NLS
|  	help
|  	  This is a port of IBM's Journaled Filesystem .  More information is
|  	  available in the file Documentation/filesystems/jfs.txt.
| @@ -464,6 +465,8 @@
|  	  local network, you probably do not need an automounter, and can say
|  	  N here.


--
~Randy