From: Andi Kleen <ak@suse.de>
To: John Levon <levon@movementarian.org>
Cc: Andi Kleen <ak@suse.de>, Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [AMD64 1/3] fix C99-style declarations
Date: Sat, 25 Oct 2003 22:56:17 +0200 [thread overview]
Message-ID: <20031025205617.GD27754@wotan.suse.de> (raw)
In-Reply-To: <20031025204717.GA78345@compsoc.man.ac.uk>
On Sat, Oct 25, 2003 at 09:47:17PM +0100, John Levon wrote:
> On Sat, Oct 25, 2003 at 10:27:50PM +0200, Andi Kleen wrote:
>
> > x86-64 always used C99 and there is no x86-64 compiler
> > around that doesn't support it. I must say I was somewhat pissed off
> > that someone added that nasty warning to the toplevel Makefile
> > just to comfort some gcc 2.95 users on i386 ("all world is a i386")
>
> Sorry, that is bullshit. The change was entirely designed to prevent
> people on such architectures hacking general files where there *do*
> exist older compilers, to avoid breakage being introduced without it
> being flagged.
I don't think it makes much difference. People hacking on one architecture
break other architectures all the time for various reasons, e.g.
the implicit includes in different architectures vary widely.
The few people left who use 2.95 will just have to live with
occasional breakage when they insist on using a non standards
compliant compiler.
>
> This has happened more than once in the tree.
>
> When all the architectures have a minimum gcc requirement that accepts
> mixed code and declarations by default, it can be removed ...
Would be my prefered solution. Discourage 2.95.
Sooner or later we have to do that anyways when a bug in 2.95
is found that breaks code (has happened with all gccs so far).
Sooner would be better, as supporting 2.95 seems to be already
a significant mainteance burden.
-Andi
next prev parent reply other threads:[~2003-10-25 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-25 18:28 [AMD64 1/3] fix C99-style declarations Jeff Garzik
2003-10-25 20:27 ` Andi Kleen
2003-10-25 20:47 ` John Levon
2003-10-25 20:56 ` Andi Kleen [this message]
2003-10-25 21:03 ` John Levon
2003-10-28 9:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031025205617.GD27754@wotan.suse.de \
--to=ak@suse.de \
--cc=jgarzik@pobox.com \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox