From: Rob Landley <rob@landley.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, Roman Zippel <zippel@linux-m68k.org>
Subject: [patch] make Kconfig choice menu help text work in -test8
Date: Sat, 25 Oct 2003 22:16:02 -0500 [thread overview]
Message-ID: <200310252216.08065.rob@landley.net> (raw)
In-Reply-To: <20031025213027.GB2249@mars.ravnborg.org>
> > (Looking at the patch, it prints stuff to stderr, adds adds a "selected"
> > case to something that was previously on/off... I don't think it's
> > really addressing this issue...)
>
> That explains why Roman Zippel did not apply it - thanks for the testing.
>
> Sam
I had a spare couple of hours this evening, so I whipped up a patch of my
own to actually fix the thing, working from first principles and tracing
through yacc and lexx code at one point.
With the benefit of hindsight, it turns out the other patch wasn't actually
that far off. I only noticed that just now, I had to figure out how mconf.c
was shelling out to lxdialog and getting data back on stderr first to
realize that yes, printing stuff to stderr is in fact an important part of
getting this to work. :)
Here's the fix. Go to into "processor type and features" from the main
menu, then the "subarchitecture" menu at the top of that, and notice the
entries in it now have help options.
Rob
diff -ru linux-2.6.0-test8/scripts/kconfig/mconf.c linux-test8-new/scripts/kconfig/mconf.c
--- linux-2.6.0-test8/scripts/kconfig/mconf.c 2003-10-17 16:42:56.000000000 -0500
+++ linux-test8-new/scripts/kconfig/mconf.c 2003-10-25 21:59:31.000000000 -0500
@@ -635,7 +635,9 @@
sym_set_tristate_value(menu->sym, yes);
return;
case 1:
- show_help(menu);
+ if(sscanf(input_buf, "%p", &child) != 1)
+ break;
+ show_help(child);
break;
case 255:
return;
diff -ru linux-2.6.0-test8/scripts/lxdialog/checklist.c linux-test8-new/scripts/lxdialog/checklist.c
--- linux-2.6.0-test8/scripts/lxdialog/checklist.c 2003-10-17 16:43:10.000000000 -0500
+++ linux-test8-new/scripts/lxdialog/checklist.c 2003-10-25 21:56:04.000000000 -0500
@@ -299,12 +299,6 @@
continue; /* wait for another key press */
}
switch (key) {
- case 'H':
- case 'h':
- case '?':
- delwin (dialog);
- free (status);
- return 1;
case TAB:
case KEY_LEFT:
case KEY_RIGHT:
@@ -314,6 +308,11 @@
print_buttons(dialog, height, width, button);
wrefresh (dialog);
break;
+ case 'H':
+ case 'h':
+ case '?':
+ button=1;
+ /* Fall through */
case 'S':
case 's':
case ' ':
@@ -347,7 +346,9 @@
}
}
- }
+ } else {
+ fprintf(stderr,"%s",items[choice * 3]);
+ }
delwin (dialog);
free (status);
return button;
prev parent reply other threads:[~2003-10-26 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-25 7:44 Kconfig choice menu help text is not working in -test8 Rob Landley
2003-10-25 11:26 ` Sam Ravnborg
2003-10-25 21:24 ` Rob Landley
2003-10-25 21:30 ` Sam Ravnborg
2003-10-26 3:16 ` Rob Landley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310252216.08065.rob@landley.net \
--to=rob@landley.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox