From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Stephen Smalley <sds@epoch.ncsc.mil>,
jmorris@redhat.com,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: 2.6.0-test9: selinux compile error with "make O=..."
Date: Sun, 26 Oct 2003 10:49:23 +0100 [thread overview]
Message-ID: <20031026094923.GA925@mars.ravnborg.org> (raw)
In-Reply-To: <20031026002209.GD23291@fs.tum.de>
On Sun, Oct 26, 2003 at 02:22:09AM +0200, Adrian Bunk wrote:
> The problem comes from the following line in
> security/selinux/ss/Makefile:
> EXTRA_CFLAGS += -Isecurity/selinux/include -include security/selinux/ss/global.h
Hi Adrian.
Known problem that has been reported back to the maintainers about
one month ago. But they do not seem to care enough to fix it.
The use of "-include" is a bad way to include files. The reader will
not see that global.h is included at all and will wonder how that
information get pulled in.
Furhtermore the location of the header files under security/include
is considered bad practice. All headerfiles used from more than one
directory belongs to include/xxx, in this case include/security.
Then they can be included using
#include <security/secuity.h>
Everything are post 2.6.0 material.
Sam
next prev parent reply other threads:[~2003-10-26 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-25 19:09 Linux 2.6.0-test9 Linus Torvalds
2003-10-25 19:52 ` Marcelo Tosatti
2003-10-25 20:14 ` viro
2003-10-25 22:35 ` Linus Torvalds
2003-10-25 23:45 ` Jose Luis Domingo Lopez
2003-10-26 0:22 ` 2.6.0-test9: selinux compile error with "make O=..." Adrian Bunk
2003-10-26 9:49 ` Sam Ravnborg [this message]
2003-10-27 13:40 ` Stephen Smalley
2003-10-27 18:42 ` Sam Ravnborg
2003-10-28 15:10 ` Stephen Smalley
2003-10-26 12:05 ` Linux 2.6.0-test9 Patrik Wallstrom
2003-10-27 18:21 ` Patrik Wallstrom
2003-10-27 22:51 ` bill davidsen
2003-10-28 2:12 ` Jeff Garzik
2003-10-28 4:52 ` Bill Davidsen
2003-10-26 15:05 ` Linux 2.4 <-> 2.6 compatibility (was: Linux 2.6.0-test9) Matthias Andree
2003-10-26 15:18 ` Linux 2.4 <-> 2.6 compatibility Måns Rullgård
2003-10-27 2:51 ` Matthias Andree
2003-10-26 16:06 ` Jochen Hein
2003-10-26 17:47 ` Fabio Massimo Di Nitto
2003-10-26 18:18 ` Jochen Hein
2003-10-27 16:02 ` Linux 2.6.0-test9 (compile stats) John Cherry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031026094923.GA925@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@fs.tum.de \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox