From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263039AbTJZJtf (ORCPT ); Sun, 26 Oct 2003 04:49:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263050AbTJZJtb (ORCPT ); Sun, 26 Oct 2003 04:49:31 -0500 Received: from pasmtp.tele.dk ([193.162.159.95]:15623 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S263039AbTJZJt1 (ORCPT ); Sun, 26 Oct 2003 04:49:27 -0500 Date: Sun, 26 Oct 2003 10:49:23 +0100 From: Sam Ravnborg To: Adrian Bunk Cc: Stephen Smalley , jmorris@redhat.com, Kernel Mailing List , Sam Ravnborg Subject: Re: 2.6.0-test9: selinux compile error with "make O=..." Message-ID: <20031026094923.GA925@mars.ravnborg.org> Mail-Followup-To: Adrian Bunk , Stephen Smalley , jmorris@redhat.com, Kernel Mailing List , Sam Ravnborg References: <20031026002209.GD23291@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031026002209.GD23291@fs.tum.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 26, 2003 at 02:22:09AM +0200, Adrian Bunk wrote: > The problem comes from the following line in > security/selinux/ss/Makefile: > EXTRA_CFLAGS += -Isecurity/selinux/include -include security/selinux/ss/global.h Hi Adrian. Known problem that has been reported back to the maintainers about one month ago. But they do not seem to care enough to fix it. The use of "-include" is a bad way to include files. The reader will not see that global.h is included at all and will wonder how that information get pulled in. Furhtermore the location of the header files under security/include is considered bad practice. All headerfiles used from more than one directory belongs to include/xxx, in this case include/security. Then they can be included using #include Everything are post 2.6.0 material. Sam