public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marco Roeland <marco.roeland@xs4all.nl>
To: wsy@merl.com
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: compile-time error in 2.6.0-test9
Date: Sun, 26 Oct 2003 17:24:22 +0100	[thread overview]
Message-ID: <20031026162422.GB23792@localhost> (raw)
In-Reply-To: <200310261553.h9QFrb513039@localhost.localdomain>

On Sunday Oktober 26th 2003 at 10:53 uur wsy@merl.com wrote:

> 
> [1.] One line summary of the problem:    
> 
> compile-time error in fresh, unpatched 2.6.0-test9

Yes, this is a compiler bug in gcc 2.96 you're hitting. Two separate
patches have been posted that fix it (one from Shane Shrybman and one by
me). Here's my version (tested by Norman Diamond):

--- linux-2.6.0-test8/fs/proc/array.c.orig	2003-10-21 16:18:40.000000000 +0200
+++ linux-2.6.0-test8/fs/proc/array.c	2003-10-23 09:30:27.000000000 +0200
@@ -302,6 +302,7 @@
 	pid_t ppid;
 	int num_threads = 0;
 	struct mm_struct *mm;
+	unsigned long long starttime;
 
 	state = *get_task_state(task);
 	vsize = eip = esp = 0;
@@ -343,9 +344,7 @@
 	read_lock(&tasklist_lock);
 	ppid = task->pid ? task->real_parent->pid : 0;
 	read_unlock(&tasklist_lock);
-	res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \
-%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu \
-%lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n",
+	res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu ",
 		task->pid,
 		task->comm,
 		state,
@@ -355,7 +354,9 @@
 		tty_nr,
 		tty_pgrp,
 		task->flags,
-		task->min_flt,
+		task->min_flt);
+	starttime = jiffies_64_to_clock_t(task->start_time - INITIAL_JIFFIES);
+	res += sprintf(buffer + res,"%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu ",
 		task->cmin_flt,
 		task->maj_flt,
 		task->cmaj_flt,
@@ -367,15 +368,15 @@
 		nice,
 		num_threads,
 		jiffies_to_clock_t(task->it_real_value),
-		(unsigned long long)
-		    jiffies_64_to_clock_t(task->start_time - INITIAL_JIFFIES),
+		starttime,
 		vsize,
 		mm ? mm->rss : 0, /* you might want to shift this left 3 */
 		task->rlim[RLIMIT_RSS].rlim_cur,
 		mm ? mm->start_code : 0,
 		mm ? mm->end_code : 0,
 		mm ? mm->start_stack : 0,
-		esp,
+		esp);
+	res += sprintf(buffer + res,"%lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n",
 		eip,
 		/* The signal information here is obsolete.
 		 * It must be decimal for Linux 2.0 compatibility.

  reply	other threads:[~2003-10-26 16:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-26 15:53 compile-time error in 2.6.0-test9 wsy
2003-10-26 16:24 ` Marco Roeland [this message]
2003-10-26 16:35   ` wsy
2003-10-26 17:16     ` Marco Roeland
2003-10-26 23:19       ` wsy
2003-10-26 23:51         ` David Rees
2003-10-27  0:09           ` wsy
2003-10-27  2:26             ` Guy
2003-10-27 11:21         ` Ookhoi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031026162422.GB23792@localhost \
    --to=marco.roeland@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsy@merl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox