public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stelian Pop <stelian@popies.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: marcelo.tosatti@cyclades.com
Subject: [PATCH 2.4.23-pre8] ieee1394 nodemgr deadlock
Date: Sun, 26 Oct 2003 17:49:16 +0100	[thread overview]
Message-ID: <20031026164916.GS4013@deep-space-9.dsnet> (raw)

Hi,

This patch was submitted here a while ago, has been ack'ed by 
Ben Collins but it still hasn't made it into the 2.4 tree.

Marcelo, please apply it, without this patch kudzu deadlocks
on every boot on my RedHat laptop.

Thanks,

Stelian.

===== drivers/ieee1394/nodemgr.c 1.23 vs edited =====
--- 1.23/drivers/ieee1394/nodemgr.c	Sat Jul 19 18:11:56 2003
+++ edited/drivers/ieee1394/nodemgr.c	Mon Sep 29 10:31:17 2003
@@ -1317,8 +1317,10 @@
 		 * to make sure things settle down. */
 		for (i = 0; i < 4 ; i++) {
 			set_current_state(TASK_INTERRUPTIBLE);
-			if (schedule_timeout(HZ/16))
+			if (schedule_timeout(HZ/16)) {
+				up(&nodemgr_serialize);
 				goto caught_signal;
+			}
 
 			/* Now get the generation in which the node ID's we collect
 			 * are valid.  During the bus scan we will use this generation
-- 
Stelian Pop <stelian@popies.net>

                 reply	other threads:[~2003-10-26 16:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031026164916.GS4013@deep-space-9.dsnet \
    --to=stelian@popies.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox