public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dave Jones <davej@redhat.com>, "Luck, Tony" <tony.luck@intel.com>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	marcelo@conectiva.com.br
Subject: Re: [PATCH 2.4.23-pre8]  Remove broken prefetching in free_one_pgd()
Date: Mon, 27 Oct 2003 10:52:59 +0100	[thread overview]
Message-ID: <20031027095259.GA312@elf.ucw.cz> (raw)
In-Reply-To: <20031026145156.GB28572@redhat.com>

Hi!

>  > > This code will prefetch from beyond the end of the page table
>  > > being cleared ... which is clearly a bad thing if the page table
>  > > in question is allocated from the last page of memory (or precedes
>  > > a hole on a discontig mem system).
>  > Prefetching random addresses should be safe...
> 
> It isn't on some CPUs.  Early athlons go bang when you prefetch
> past the end of RAM into unmapped memory for eg.

Well, broken HW :-(, but andi's patch should fix up for that.

								Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  reply	other threads:[~2003-10-27  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-24 20:56 [PATCH 2.4.23-pre8] Remove broken prefetching in free_one_pgd() Luck, Tony
2003-10-24 22:01 ` David Mosberger
2003-10-25 20:10 ` Pavel Machek
2003-10-26 14:51   ` Dave Jones
2003-10-27  9:52     ` Pavel Machek [this message]
2003-10-27 11:58       ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2003-10-24 22:16 Luck, Tony
2003-10-24 22:21 ` David Mosberger
2003-10-30 20:57   ` Bjorn Helgaas
2003-10-30 21:36 Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031027095259.GA312@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=bjorn.helgaas@hp.com \
    --cc=davej@redhat.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox