From: Matt Domsch <Matt_Domsch@dell.com>
To: Patrick Mochel <mochel@osdl.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: Ref-count problem in kset_find_obj?
Date: Wed, 29 Oct 2003 23:42:54 -0600 [thread overview]
Message-ID: <20031029234254.A13162@lists.us.dell.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0310291623420.1023-100000@cherise>; from mochel@osdl.org on Wed, Oct 29, 2003 at 04:24:58PM -0800
On Wed, Oct 29, 2003 at 04:24:58PM -0800, Patrick Mochel wrote:
>
> > The reference count of the kobject to be returned is not
> > increased before the semaphore is released. A kobject_del/unlink
> > could remove the object before the called of kset_find_obj is
> > able to increase the reference count. This makes kset_find_obj
> > more or less unusable, doesn't it?
>
> Yes, you're right. The function is pretty much unused, and I don't have a
> problem removing it, provided we can fix up the one user
> (arch/i386/kernel/edd.c). Unless of course, you're planning on using it..
At the moment, edd.c doesn't actually use it. It wants to -
find_bus() is a useful concept, but I haven't proven that the scsi_bus
list only has scsi_devices on it, so that code isn't compiled in at
present. If the scsi_bus list is clean now, then yes, I'll want to
turn it back on (after 2.6.0 is out) and will need find_bus() to be
possible.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2003-10-30 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-29 12:38 Ref-count problem in kset_find_obj? Martin Schwidefsky
2003-10-30 0:24 ` Patrick Mochel
2003-10-30 5:42 ` Matt Domsch [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-30 8:46 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031029234254.A13162@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox