From: viro@parcelfarce.linux.theplanet.co.uk
To: Andrew Morton <akpm@osdl.org>
Cc: "Jeffrey E. Hundstad" <jeffrey.hundstad@mnsu.edu>,
linux-kernel@vger.kernel.org
Subject: Re: /proc/[0-9]*/maps where did the (deleted) status go?
Date: Sun, 2 Nov 2003 08:58:19 +0000 [thread overview]
Message-ID: <20031102085818.GG7665@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20031102004739.12a0004c.akpm@osdl.org>
On Sun, Nov 02, 2003 at 12:47:39AM -0800, Andrew Morton wrote:
> This patch (against 2.6) will restore the old 2.4 behaviour. I'll scoot
> the 2.4 equiv over to Marcelo.
>
> diff -puN fs/proc/task_mmu.c~proc-pid-maps-output-fix fs/proc/task_mmu.c
> --- 25/fs/proc/task_mmu.c~proc-pid-maps-output-fix 2003-11-02 00:38:26.000000000 -0800
> +++ 25-akpm/fs/proc/task_mmu.c 2003-11-02 00:38:30.000000000 -0800
> @@ -106,7 +106,7 @@ static int show_map(struct seq_file *m,
> if (len < 1)
> len = 1;
> seq_printf(m, "%*c", len, ' ');
> - seq_path(m, file->f_vfsmnt, file->f_dentry, " \t\n\\");
> + seq_path(m, file->f_vfsmnt, file->f_dentry, "");
> }
> seq_putc(m, '\n');
> return 0;
It's still wrong - the real bug is in seq_path(); the thing should *not*
try to escape anything in " (deleted)" part.
prev parent reply other threads:[~2003-11-02 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-02 3:49 /proc/[0-9]*/maps where did the (deleted) status go? Jeffrey E. Hundstad
2003-11-02 7:52 ` Andrew Morton
2003-11-02 8:17 ` Jeffrey E. Hundstad
2003-11-02 8:47 ` Andrew Morton
2003-11-02 8:58 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031102085818.GG7665@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=jeffrey.hundstad@mnsu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox