public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BIO] Bounce queue in bio_add_page
Date: Fri, 7 Nov 2003 12:32:35 +0100	[thread overview]
Message-ID: <20031107113235.GD591@suse.de> (raw)
In-Reply-To: <20031107112833.GA5239@gondor.apana.org.au>

On Fri, Nov 07 2003, Herbert Xu wrote:
> On Fri, Nov 07, 2003 at 12:25:55PM +0100, Jens Axboe wrote:
> > 
> > Could be related, someone is doing an unlock on an already unlocked
> > page. Is this the same system that saw the bounce problem initially?
> 
> Yes, see http://bugs.debian.org/218566 for details.

Then there's likely just some other bug wrt bouncing. Hmm, does this
work?

===== mm/highmem.c 1.47 vs edited =====
--- 1.47/mm/highmem.c	Thu Oct  9 15:03:32 2003
+++ edited/mm/highmem.c	Fri Nov  7 12:32:03 2003
@@ -402,6 +402,8 @@
 		to->bv_len = from->bv_len;
 		to->bv_offset = from->bv_offset;
 
+		lock_page(to->bv_page);
+
 		if (rw == WRITE) {
 			char *vto, *vfrom;
 

-- 
Jens Axboe


  reply	other threads:[~2003-11-08  0:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-01  4:46 [BIO] Bounce queue in bio_add_page Herbert Xu
2003-11-01 10:05 ` Herbert Xu
2003-11-03 12:25   ` Jens Axboe
2003-11-03 20:52     ` Herbert Xu
2003-11-04  8:49       ` Jens Axboe
2003-11-04  9:03         ` Herbert Xu
2003-11-04  9:03           ` Jens Axboe
2003-11-05  9:48             ` Jens Axboe
2003-11-06 21:09               ` Herbert Xu
2003-11-07 11:23                 ` Herbert Xu
2003-11-07 11:25                   ` Jens Axboe
2003-11-07 11:28                     ` Herbert Xu
2003-11-07 11:32                       ` Jens Axboe [this message]
2003-11-07 22:52                         ` Herbert Xu
2003-11-08  9:29                           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031107113235.GD591@suse.de \
    --to=axboe@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox