Re: SFFDC and blksize_size

[Jens Axboe <axboe@suse.de>]

On Mon, Nov 10 2003, David Woodhouse wrote:
> On Mon, 2003-11-10 at 15:09 +0100, Jens Axboe wrote:
> > On Fri, Nov 07 2003, Simon Haynes wrote:
> > > 
> > > I have been writing a block driver for SSFDC compliant SMC cards. This stuff 
> > > allocates 16k blocks.  When I get requests the transfers are split into the 
> > > size I specifty in the blksize_size{MAJOR] array. It sems that most things 
> > 
> > Sounds like a bad way to do it. It's much better to prevent builds of
> > bigger requests than you can handle in one go. You don't mention what
> > kernel you are using, but both 2.4 and 2.6 can do this for you.
> 
> The problem is the other way round -- he wants request merging, and he's
> achieving this by setting the block size higher.... and observing a
> crash when he sets his block size higher than PAGE_SIZE.

Yes I know, but he doesn't want requests merged > 16k, right? So it's
stupid to allow these to get through.

-- 
Jens Axboe