From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: Daniel Craig <dancraig@internode.on.net>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test9-bk16 ALi M5229 kernel boot error
Date: Wed, 12 Nov 2003 04:31:34 +0000 [thread overview]
Message-ID: <20031112043133.GD24159@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0311111901490.1694-100000@home.osdl.org>
On Tue, Nov 11, 2003 at 07:04:17PM -0800, Linus Torvalds wrote:
> Yes. The ALI driver has some really strange code to avoid tweaking non-ALI
> southbridges.
>
> But the thing is, it breaks even _with_ ALI southbridges, if we just don't
> find the ALI bridge we expect.
>
> Does this patch fix it?
> - if (north && north->vendor != PCI_VENDOR_ID_AL) {
> + if (!isa_dev) {
Wrong fix, AFAICS. Original condition is bogus, no arguments here.
However, the point is
"tweak our southbridge only if northbridge is known to be OK with that"
and not
"tweak southbridge only if it's ours"
IOW, proper check is || of those two.
next prev parent reply other threads:[~2003-11-12 4:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 2:46 2.6.0-test9-bk16 ALi M5229 kernel boot error Daniel Craig
2003-11-12 3:04 ` Linus Torvalds
2003-11-12 3:50 ` Jeff Garzik
2003-11-12 4:36 ` viro
2003-11-12 5:29 ` Linus Torvalds
2003-11-12 4:21 ` Daniel Craig
2003-11-12 4:31 ` viro [this message]
2003-11-12 6:58 ` David S. Miller
2003-11-12 15:06 ` Ivan Kokshaysky
2003-11-12 15:52 ` Linus Torvalds
2003-11-12 16:39 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031112043133.GD24159@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=dancraig@internode.on.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox