From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Bootmem broke ARM
Date: Sun, 16 Nov 2003 10:15:35 +0000 [thread overview]
Message-ID: <20031116101535.A592@flint.arm.linux.org.uk> (raw)
Andrew & others,
2.6 contains a change to init_bootmem_core() which now sorts the nodes
according to their start pfn. This change occurred in revision 1.20 of
bootmem.c. Unfortunately, this active sorting broke ARM discontig memory
support.
With previous kernels, the nodes are added to the list in reverse order,
so architecture code knew we had to add the highest PFN first and the
lowest PFN node last.
However, we now sort the nodes using node_start_pfn, which, at this point,
will be uninitialised - the responsibility for initialising this field
is with the generic code - in free_area_init_node() which occurs well
after bootmem has been initialised.
The result of this change is that we now add nodes to the tail of the
pgdat list, which is the opposite way to 2.4.
This causes problems for ARM because we need to use bootmem to initialise
the kernels page tables, and we can only allocate these from node 0 - none
of the other nodes are mapped into memory at this point.
I, therefore, believe this change is bogus. Can it be reverted please?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next reply other threads:[~2003-11-16 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-16 10:15 Russell King [this message]
2003-11-16 20:11 ` Bootmem broke ARM Andrew Morton
2003-11-17 18:04 ` Jesse Barnes
2003-11-18 9:42 ` Russell King
2003-11-18 9:57 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031116101535.A592@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox