public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hoskings <ben@jeeves.bpa.nu>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Nico Schottelius <nico-mutt@schottelius.org>
Subject: Re: transmeta cpu code question
Date: Thu, 20 Nov 2003 12:10:04 +1000	[thread overview]
Message-ID: <200311201210.04780.ben@jeeves.bpa.nu> (raw)
In-Reply-To: <20031120020218.GJ3748@schottelius.org>

On Thu, 20 Nov 2003 12:02 pm, Nico Schottelius wrote:
> Hello!
>
> What does this do:
>
>                 printk(KERN_INFO "CPU: Processor revision %u.%u.%u.%u,
> %u MHz\n",
>                        (cpu_rev >> 24) & 0xff,
>                        (cpu_rev >> 16) & 0xff,
>                        (cpu_rev >> 8) & 0xff,
>                        cpu_rev & 0xff,
>                        cpu_freq);
>
> (from arch/i386/kernel/cpu/transmeta.c)
>
> Does not & 0xff make no sense? 0 & 1 makes 0, 1 & 1 makes 1,
> no changes.

I may be wrong, but afaik the 0xff's are there to truncate the other values to 
8-bit. 0xff == 0b11111111, which is 8-bit.

>From the bitshifting above, cpu_rev seems to be a 32-bit value, so the four 
sections of cpu_rev (>>24, >>16, >>8 and >>0) are being ANDed with 0xff to 
show only the 8 low bits (post-shift).

>
> And I don't understand why we do this for 8bit and shifting the
> cpu_rev...
>
> Can someone enlighten me (with CC' as I am not subscribed) ?
>
> Nico
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben


  reply	other threads:[~2003-11-20  2:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-20  2:02 transmeta cpu code question Nico Schottelius
2003-11-20  2:10 ` Ben Hoskings [this message]
2003-11-20  8:38   ` Nico Schottelius
2003-11-20 17:33     ` H. Peter Anvin
2003-11-20 23:25       ` Jamie Lokier
2003-11-21  8:34         ` John Bradford
2003-11-21  8:48           ` Jamie Lokier
2003-11-24  6:54             ` H. Peter Anvin
2003-11-24 13:19               ` Jamie Lokier
2003-11-20  2:53 ` Ben Collins
2003-11-20  3:06   ` Kevin P. Fleming
2003-11-20 13:25     ` Ben Collins
2003-11-20  3:18   ` Ben Hoskings
2003-11-20  6:57   ` Eric Sandall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200311201210.04780.ben@jeeves.bpa.nu \
    --to=ben@jeeves.bpa.nu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico-mutt@schottelius.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox