The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Arkadiusz Miskiewicz <arekm@pld-linux.org>,
	Alan Cox <alan@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: modular IDE in 2.4.23
Date: Sun, 23 Nov 2003 15:56:35 -0500	[thread overview]
Message-ID: <20031123205635.GA20672@devserv.devel.redhat.com> (raw)
In-Reply-To: <200311232123.06635.bzolnier@elka.pw.edu.pl>

> Uh. Oh. 2.4.23 IDE changes are obscure...  Modular IDE breakage is caused by
> Alan's hotplug changes and is not easy to fix properly.

The fixing is simply a matter of linkage ordering and function execution. 

Simple thought experiment

	Merge ide-probe into ide-core
	Export a symbol for the second initializer function if used modular
	Create a mini module that just invokes the exported function on init

You now have the same execution sequence but with the link problem removed.

> I would like to have these changes removed:
> (a) they break modular IDE
> (b) such changes should be first added to 2.6 and then backported to 2.4
>    (otherwise you are magically creating regression in 2.6)

Its not my fault the 2.6 code is lagging badly, and I wrote the code
because people using laptops, and people using ATA and SATA for business
expect basic functionality like hotplug to work. For most of them 2.6 doesn't
really matter and won't for another 6 months, but 2.4 matters right now.

The cmd640 stuff is the only hard to fix bit, and its unrelated to the
modular IDE stuff.


  reply	other threads:[~2003-11-23 20:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200311231310.38793.arekm@pld-linux.org>
2003-11-23 17:08 ` modular IDE in 2.4.23 Marcelo Tosatti
2003-11-23 20:23   ` Bartlomiej Zolnierkiewicz
2003-11-23 20:56     ` Alan Cox [this message]
2003-11-23 21:26       ` Bartlomiej Zolnierkiewicz
2003-11-23 21:49         ` Alan Cox
2003-11-24  0:25         ` Marcelo Tosatti
2003-11-24  9:15           ` Alan Cox
2003-11-24  0:22     ` Marcelo Tosatti
2003-11-24  0:50       ` Arkadiusz Miskiewicz
2003-11-24  9:19         ` Alan Cox
2003-11-22 16:46 Arkadiusz Miskiewicz
2003-11-22 17:31 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031123205635.GA20672@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=arekm@pld-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox