public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Jack Steiner <steiner@sgi.com>,
	jes@trained-monkey.org, viro@math.psu.edu, wli@holomorphy.com,
	linux-kernel@vger.kernel.org, jbarnes@sgi.com
Subject: Re: hash table sizes
Date: Tue, 2 Dec 2003 08:06:01 +1100	[thread overview]
Message-ID: <20031201210601.GC22620@krispykreme> (raw)
In-Reply-To: <20031125130741.108bf57c.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

 
Hi,

> Well yes.  I suspect the inode hashtable could be shrunk; I don't think we
> do hash-based inode lookups very much?

Id be interested to know how often we hit the inode hash. Last time I
looked at it, there were some real deep chains due (Im guessing) to
the way ext2 inode allocation causes them to end up in groups.

The attached graph shows what is going on. The histogram below shows its
not as bad as I thought, most of the distribution is in the 0-1 bucket
range.

> It would be very nice to have some confirmation that the size of these
> tables is being appropriately chosen, too.  Maybe we should shrink 'em 32x
> and see who complains...

Why dont we just do node round robin allocations during boot? This
should mean the static boot time hashes would at least end up on
different nodes.

Anton

0 248652
1 7374
2 77
3 71
4 72
5 109
6 61
7 75
8 114
9 54
10 34
11 45
12 58
13 35
14 37
15 39
16 32
17 30
18 36
19 31
20 31
21 43
22 47
23 52
24 30
25 26
26 31
27 35
28 35
29 38
30 39
31 38
32 43
33 40
34 49
35 43
36 41
37 44
38 47
39 49
40 51
41 67
42 66
43 104
44 166
45 195
46 289
47 372
48 467
49 542
50 589
51 516
52 436
53 271
54 100
55 53
56 22
57 0
58 1

[-- Attachment #2: inode_cache.png --]
[-- Type: image/png, Size: 10241 bytes --]

  parent reply	other threads:[~2003-12-01 21:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-25 13:35 hash table sizes Jes Sorensen
2003-11-25 13:42 ` William Lee Irwin III
2003-11-25 13:54   ` Jes Sorensen
2003-11-25 16:25     ` Thomas Schlichter
2003-11-25 17:52       ` Antonio Vargas
2003-11-25 17:54         ` William Lee Irwin III
2003-11-25 20:48 ` Jack Steiner
2003-11-25 21:07   ` Andrew Morton
2003-11-25 21:14     ` Jesse Barnes
2003-11-25 21:24       ` Andrew Morton
2003-11-26  2:14         ` David S. Miller
2003-11-26  5:27         ` Matt Mackall
2003-11-28 14:15         ` Jes Sorensen
2003-11-28 14:52           ` Jack Steiner
2003-11-28 16:22             ` Jes Sorensen
2003-11-28 19:35               ` Jack Steiner
2003-11-28 21:18                 ` Jörn Engel
2003-12-01  9:46                   ` Jes Sorensen
2003-12-01 21:06     ` Anton Blanchard [this message]
2003-12-01 22:57       ` Martin J. Bligh
2003-11-25 21:16   ` Anton Blanchard
2003-11-25 23:11     ` Jack Steiner
2003-11-26  3:39       ` Rik van Riel
2003-11-26  3:59         ` William Lee Irwin III
2003-11-26  4:25           ` Andrew Morton
2003-11-26  4:23             ` William Lee Irwin III
2003-11-26  5:14           ` Martin J. Bligh
2003-11-26  9:51             ` William Lee Irwin III
2003-11-26 16:17               ` Martin J. Bligh
2003-11-26  7:25       ` Anton Blanchard
  -- strict thread matches above, loose matches on Subject: below --
2003-11-26  5:53 Zhang, Yanmin
2003-11-29 10:39 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031201210601.GC22620@krispykreme \
    --to=anton@samba.org \
    --cc=akpm@osdl.org \
    --cc=jbarnes@sgi.com \
    --cc=jes@trained-monkey.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=viro@math.psu.edu \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox