From: Michael Frank <mhf@linuxmail.org>
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Laptop mode and 2.4.23
Date: Tue, 2 Dec 2003 15:14:06 +0800 [thread overview]
Message-ID: <200312020741.05319.mhf@linuxmail.org> (raw)
Using laptop mode for the first time. Kernel is 2.4.23-Vanilla+kdb4.3 on a x86 notebook.
IDE Disk is ext3 mounted with rw,noatime
# cat /proc/sys/vm/laptop_mode
1
# cat /proc/sys/vm/bdflush
30 500 0 0 60000 60000 60 20 0
- Any disk write access spins up and writes as usual after 5 seconds by kjournald
- A disk spinup by kjournald does _not_ run bdflush and kupdated, so once they
elapse, the disk spins up again
This part of the laptop-mode patch is missing and the 5 second interval is still hardcoded:
diff -Nru a/fs/jbd/transaction.c b/fs/jbd/transaction.c
--- a/fs/jbd/transaction.cWed May 14 11:29:52 2003
+++ b/fs/jbd/transaction.cWed May 14 11:29:52 2003
@@ -56,7 +56,11 @@
transaction->t_journal = journal;
transaction->t_state = T_RUNNING;
transaction->t_tid = journal->j_transaction_sequence++;
-transaction->t_expires = jiffies + journal->j_commit_interval;
+/*
+ * have to do it here, otherwise changed age_buffers since boot
+ * wont have any effect
+ */
+transaction->t_expires = jiffies + get_buffer_flushtime();
INIT_LIST_HEAD(&transaction->t_jcb);
IMHO, without this patch, laptop-mode is only half as useful ;)
Why was this part of the patch not used?
Regards
Michael
reply other threads:[~2003-12-02 7:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312020741.05319.mhf@linuxmail.org \
--to=mhf@linuxmail.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox