From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261311AbTLCUk3 (ORCPT ); Wed, 3 Dec 2003 15:40:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261406AbTLCUk3 (ORCPT ); Wed, 3 Dec 2003 15:40:29 -0500 Received: from gw-oko.i4u.sk ([212.89.237.40]:28432 "EHLO 212.89.237.40") by vger.kernel.org with ESMTP id S261311AbTLCUkX (ORCPT ); Wed, 3 Dec 2003 15:40:23 -0500 Date: Wed, 3 Dec 2003 21:40:21 +0100 From: ivan vadovic To: Adam Belay Cc: rogerspl@datasync.com, linux-kernel@vger.kernel.org Subject: Re: isapnp modem working [PATCH] Message-ID: <20031203204021.GF2218@larva.oko> References: <20031111005856.GB2104@larva.oko> <20031202224337.GA3531@neo.rr.com> <20031202232512.GA14946@neo.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20031202232512.GA14946@neo.rr.com> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 02, 2003 at 11:25:12PM +0000, Adam Belay wrote: > Date: Tue, 2 Dec 2003 23:25:12 +0000 > From: Adam Belay > To: ivan vadovic > Subject: Re: isapnp modem in 2.6.0-test9-bk13 not working > > On Tue, Dec 02, 2003 at 10:43:37PM +0000, Adam Belay wrote: > > On Tue, Nov 11, 2003 at 01:58:58AM +0100, ivan vadovic wrote: > > > I've got an ordinary isapnp modem which provides a serial port unlike > > > winmodems and it just happens to work under 2.4 kernels. When I boot into > > > the 2.6 kernel on the same machine, everything ( sound, ide, md, networking, > > > input devices) seems to work right but the modem. Modprobing 8250_pnp only > > > detects the 2 onboard serial ports. Am I doing anything wrong? What am I > > > supposed to test? Should I provide any more info? Please Cc me as I'm not > > > on the list. > > > > > > > Could you try this patch. > > > > --- a/drivers/serial/8250_pnp.c 2003-11-26 20:42:52.000000000 +0000 > > +++ b/drivers/serial/8250_pnp.c 2003-12-02 22:41:04.000000000 +0000 > > @@ -310,6 +310,8 @@ > > { "PNPCXXX", UNKNOWN_DEV }, > > /* More unkown PnP modems */ > > { "PNPDXXX", UNKNOWN_DEV }, > > + /* check all devices and guess if they are modems */ > > + { "ANYDEVS", UNKNOWN_DEV }, > > { "", 0 } > > }; > > > > Thanks, > > Adam > > > > On second thought this isn't a very good idea because of the way the current > code enables devices on a match. Instead I'll need the EISA ID for your modem. > You can find it by catting /proc/isapnp in 2.4 or through sysfs in 2.6. > > Thanks, > Adam Well, your patch works if I modify it a little. And here goes the proper fix ( or is it?) --- linux-2.6.0-test5/drivers/serial/8250_pnp.c 2003-12-03 21:30:15.064886440 +0100 +++ ivan/drivers/serial/8250_pnp.c 2003-12-03 21:31:20.805892288 +0100 @@ -259,6 +259,8 @@ { "RSS00A0", 0 }, /* Viking 56K FAX INT */ { "RSS0262", 0 }, + /* K56 par,VV,Voice,Speakphone,AudioSpan,PnP */ + { "RSS0250", 0 }, /* SupraExpress 28.8 Data/Fax PnP modem */ { "SUP1310", 0 }, /* SupraExpress 33.6 Data/Fax PnP modem */ Wow my first kernel patch. Will I get credit in the changelog to impress my friends? Ivan Vadovic