Re: [Patch 1/4] fs.h: b_journal_head

Nathan Scott
2003-12-10T12:07:33Z

On Wed, Dec 10, 2003 at 08:46:32AM +0000, Joe Thornber wrote:
> On Wed, Dec 10, 2003 at 10:46:55AM +1100, Nathan Scott wrote:
> > Could you explain a bit more about when b_private should and
> > shouldn't be used with this change?
>
> Once the io goes through generic_make_request() you shouldn't look at
> bh->b_private until the io has completed. At which point it will have
> been correctly set back to the value it had when submitted.

OK.

> The problem with jbd wasn't the fact that it used it, but the fact
> that it peeked while the io was in flight.

Ah, I see now. XFS doesn't have to do that, so should work fine as is.

thanks.

--
Nathan