From: Andi Kleen <ak@suse.de>
To: Paul Menage <menage@google.com>
Cc: agrover@groveronline.com, linux-kernel@vger.kernel.org,
acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] ACPI global lock macros
Date: Wed, 10 Dec 2003 08:45:06 +0100 [thread overview]
Message-ID: <20031210084506.1908358a.ak@suse.de> (raw)
In-Reply-To: <3FD59441.2000202@google.com>
On Tue, 09 Dec 2003 01:22:09 -0800
Paul Menage <menage@google.com> wrote:
> Hi Andy,
>
> The ACPI_ACQUIRE_GLOBAL_LOCK() macro in include/asm-i386/acpi.h looks a
> little odd:
[...]
Thanks. I fixed the x86-64 version. RELEASE also needed similar treatment.
> Given the comments above the definition, I'm guessing that the "dummy"
> parameter was added later for some reason (to tell gcc that ecx would
> get clobbered? - but it doesn't seem to be clobbered), and the parameter
> substitutions in the asm weren't updated. Unless I'm missing something
> fundamental, shouldn't the definition be something more like this:
Numeric asm parameters are always evil and cause such bugs all the time.
gcc 3.2+ has named asm parameters which makes this much cleaner and less error prone.
Unfortunately they cannot be used in i386 because there are still people who insist
on using ancient compilers :-(
-Andi
next prev parent reply other threads:[~2003-12-10 7:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 9:22 ACPI global lock macros Paul Menage
2003-12-09 9:36 ` Arjan van de Ven
2003-12-09 9:42 ` Paul Menage
2003-12-09 9:43 ` Arjan van de Ven
2003-12-09 9:50 ` Paul Menage
2003-12-10 7:45 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-09 18:20 [ACPI] " Grover, Andrew
2003-12-09 19:04 ` Paul Menage
2003-12-09 19:03 ` David Mosberger
2003-12-11 7:06 Yu, Luming
2003-12-11 8:07 ` Andi Kleen
2003-12-11 8:27 ` Paul Menage
2003-12-11 8:20 ` Paul Menage
2003-12-11 7:27 Yu, Luming
2003-12-11 17:46 ` Nate Lawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031210084506.1908358a.ak@suse.de \
--to=ak@suse.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=agrover@groveronline.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox