From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: Matthew Reppert <repp0017@tc.umn.edu>,
Guennadi Liakhovetski <gl@dsa-ac.de>,
LKML <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@osdl.org>
Subject: Re: [OOPS] 2.6.0-test11 sysfs
Date: Wed, 10 Dec 2003 11:14:51 +0000 [thread overview]
Message-ID: <20031210111451.G16651@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20031210110632.GA1314@in.ibm.com>; from maneesh@in.ibm.com on Wed, Dec 10, 2003 at 04:36:33PM +0530
On Wed, Dec 10, 2003 at 04:36:33PM +0530, Maneesh Soni wrote:
> How is the following patch? It moves the complete() call in the "pccardd"
> thread after class_device_register(), so that in init_i82365() when
> pcmcia_register_socket() is done we are sure that class device is
> registered before creating the attribute files.
You'll either deadlock if you have a Cardbus card in the slot at
initialisation, or break standard PCMCIA cards due to a race.
The PCMCIA card race is the exact reason why class_device_register
was moved out of pcmcia_register_socket() in the first place; we
tried adding locks, but that just caused deadlock.
Basically, the only way this can be properly solved is to find some
solution to sysfs's restriction that you can't add devices for a
particular bus type from the same bus type driver's probe method.
IOW, you can't add PCI devices from a PCI device drivers probe method,
and you can't remove PCI devices from a PCI device drivers remove
method.
Pat decided that it was too risky/too late to try to fix this for 2.6,
so our only option now is to disable the problematical bits of code.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2003-12-10 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 17:35 [OOPS] 2.6.0-test11 sysfs Guennadi Liakhovetski
2003-12-09 17:57 ` Matthew Reppert
2003-12-09 18:17 ` Guennadi Liakhovetski
2003-12-09 21:14 ` Russell King
2003-12-10 9:30 ` Guennadi Liakhovetski
2003-12-10 11:06 ` Maneesh Soni
2003-12-10 11:14 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031210111451.G16651@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=gl@dsa-ac.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=mochel@osdl.org \
--cc=repp0017@tc.umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox