Re: very large FAT16 partition not readable on 2.6.0-test11

[Rogier Wolff <R.E.Wolff@BitWizard.nl>]

On Wed, Dec 10, 2003 at 10:34:46AM +0100, Andries Brouwer wrote:
> On Tue, Dec 09, 2003 at 03:03:33PM -0800, Greg KH wrote:
> 
> > I just bought a new USB/Firewire external drive.  It comes pre-formatted
> > as FAT16 (or so shows fdisk) as one big 80Gb partition.  Unfortunately,
> > Linux can't seem to mount this partition, and I get the following dmesg
> > output when trying to mount the partition:
> > 	FAT: bogus number of reserved sectors
> > 	VFS: Can't find a valid FAT filesystem on dev sdb1.

May I make a programming style suggestion? When you find a parameter
out-of-range, don't just print that it's out of range, but print the
actual value as well. This message would have become:

	FAT: Number of reserved sectors (0) out of range. 

Even better would be to print the range as well:

	FAT: Number of reserved sectors (0) out of range (1..16). 

(I just made the number up, I haven't looked in the code what the
valid range actually is...).


		Roger. 

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
**** "Linux is like a wigwam -  no windows, no gates, apache inside!" ****