Re: 2.4.23-bk bogus edd changeset - Re: 2.4.23 compile error in edd

Matt Domsch
2003-12-05T17:38:32Z

> On Thu, 4 Dec 2003, Anton Altaparmakov wrote:
> > 2.4.23-bk has a changeset (post 2.4.23 release TAG) that makes edd not
> > compile as Meelis Roos already reported:
> > > DISKSIG_BUFFER is nowhere to be seen.

Yeah, that's my bad, setup.c should say DISK80_SIG_BUFFER not
DISKSIG_BUFFER.

===== arch/i386/kernel/setup.c 1.77 vs edited =====
--- 1.77/arch/i386/kernel/setup.c Mon Dec 1 09:23:55 2003
+++ edited/arch/i386/kernel/setup.c Fri Dec 5 10:58:11 2003
@@ -211,7 +211,7 @@
#define KERNEL_START (*(unsigned long *) (PARAM+0x214))
#define INITRD_START (*(unsigned long *) (PARAM+0x218))
#define INITRD_SIZE (*(unsigned long *) (PARAM+0x21c))
-#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISKSIG_BUFFER))
+#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISK80_SIG_BUFFER))
#define EDD_NR (*(unsigned char *) (PARAM+EDDNR))
#define EDD_BUF ((struct edd_info *) (PARAM+EDDBUF))
#define COMMAND_LINE ((char *) (PARAM+2048))

With this, it works for me on my PowerEdge 4600 with disks on the
aic7xxx, and the same int13 code works on all other PowerEdge servers
we've ever tried it on. What kind of system and disks (IDE/SCSI) and
BIOS do you have for those please?

> > However, changing DISKSIG_BUFFER to DISK80_SIG_BUFFER causes the kernel to
> > reboot the computer as soon as it starts booting. Basically I select it
> > in grub and the screen changes graphics mode and by the time it has
> > finished the switch the computer reboots.

Can you send me your .config and I'll try to reproduce?

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com