public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Tram Lux <daniel@starbattle.com>
To: linux-kernel@vger.kernel.org
Subject: [patch] ide.c as a module
Date: Thu, 11 Dec 2003 21:25:36 +0100	[thread overview]
Message-ID: <20031211202536.GA10529@starbattle.com> (raw)

Hi,

I needed the ide-subsytem as a module on 2.4.23 and noticed (due to the missing modprobe on the embedded linux system)
that ide.c tries to load the module ide-probe-mod which is called ide-detect now.
The patch also get's rid of the need for ide-probe-mini alias ide-detect, but I don't know if that is desired? (it was in my case).

Regards

Daniel Lux

P.S.
please c/c me for comments. 

--- linux-2.4.23.org/drivers/ide/ide.c  2003-11-28 19:26:20.000000000 +0100
+++ linux-2.4.23/drivers/ide/ide.c      2004-03-11 20:31:51.000000000 +0100
@@ -514,11 +514,7 @@

 void ide_probe_module (int revaldiate)
 {
-       if (!ide_probe) {
-#if  defined(CONFIG_BLK_DEV_IDE_MODULE)
-               (void) request_module("ide-probe-mod");
-#endif
-       } else {
+       if (ide_probe) {
                (void) ide_probe->init();
        }
        revalidate_drives(revaldiate);
@@ -3018,13 +3014,13 @@
                banner_printed = 1;
        }

+       initializing = 1;
        init_ide_data();

 #ifndef CLASSIC_BUILTINS_METHOD
        ide_init_builtin_subdrivers();
 #endif /* CLASSIC_BUILTINS_METHOD */

-       initializing = 1;
        ide_init_builtin_drivers();
        initializing = 0;

@@ -3043,6 +3039,9 @@
 MODULE_PARM(options,"s");
 MODULE_LICENSE("GPL");

+extern int ideprobe_init_module();
+extern void ideprobe_cleanup_module (void);
+
 static void __init parse_options (char *line)
 {
        char *next = line;
@@ -3059,14 +3058,19 @@

 int init_module (void)
 {
+        int res;
+
        parse_options(options);
-       return ide_init();
+       res = ide_init();
+       ideprobe_init_module();
+       return(res);
 }

 void cleanup_module (void)
 {
        int index;
-
+
+       ideprobe_cleanup_module();
        unregister_reboot_notifier(&ide_notifier);
        for (index = 0; index < MAX_HWIFS; ++index) {
                ide_unregister(index);


             reply	other threads:[~2003-12-11 20:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-11 20:25 Daniel Tram Lux [this message]
2003-12-11 21:25 ` [patch] ide.c as a module Bartlomiej Zolnierkiewicz
2003-12-11 21:50   ` Bartlomiej Zolnierkiewicz
2003-12-12  9:20   ` Daniel Tram Lux
2003-12-12 13:30     ` Bartlomiej Zolnierkiewicz
2003-12-12 14:42       ` Daniel Tram Lux
2003-12-12 15:46         ` Bartlomiej Zolnierkiewicz
2003-12-12 17:17           ` Daniel Tram Lux
2003-12-12 17:37             ` Bartlomiej Zolnierkiewicz
2003-12-18  0:29               ` Krzysztof Halasa
2003-12-19 16:26                 ` Bartlomiej Zolnierkiewicz
2003-12-19 17:05                   ` Randy.Dunlap
2003-12-19 20:10                     ` Bartlomiej Zolnierkiewicz
2003-12-20  2:59                     ` Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031211202536.GA10529@starbattle.com \
    --to=daniel@starbattle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox