From: Anton Blanchard <anton@samba.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: prepare_to_wait/waitqueue_active issues in 2.6
Date: Sun, 14 Dec 2003 16:23:30 +1100 [thread overview]
Message-ID: <20031214052330.GN17683@krispykreme> (raw)
In-Reply-To: <Pine.LNX.4.58.0312132024270.14336@home.osdl.org>
Hi,
> Pardon my French, but this patch sure looks like crap.
I agree. Your patch wins, and that comment would even pass akpm best
practices.
> So my preference would be to add the barrier into prepare_to_wait(), along
> with a comment on why it is sometimes needed. Something like the
> appended.. (which just uses "set_current_state()", since that's what it
> exists for).
And thats pretty much how 2.4 handled the problem (set_task_state sits
between the waitqueue addition and the test). That still leaves kswapd
with problems, but in low memory conditions we'll be calling it often so
one lost wakeup here and there shouldnt matter.
Anton
next prev parent reply other threads:[~2003-12-14 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-14 3:40 prepare_to_wait/waitqueue_active issues in 2.6 Anton Blanchard
2003-12-14 3:53 ` Anton Blanchard
2003-12-14 5:02 ` Linus Torvalds
2003-12-14 5:23 ` Anton Blanchard [this message]
2003-12-14 5:35 ` Linus Torvalds
2003-12-14 8:58 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031214052330.GN17683@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox