From: Jamie Lokier <jamie@shareable.org>
To: Peter Horton <pdh@colonel-panic.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: Possible shared mapping bug in 2.4.23 (at least MIPS/Sparc)
Date: Sun, 14 Dec 2003 17:16:37 +0000 [thread overview]
Message-ID: <20031214171637.GA28923@mail.shareable.org> (raw)
In-Reply-To: <20031214103803.GA916@skeleton-jack>
Peter Horton wrote:
> I've seen code written for X86 use MAP_FIXED to create self wrapping
> ring buffers. Surely it's better to fail the mmap() on other archs
> rather than for the code to fail in unexpected ways?
Such code should test the buffers or just not create ring buffers on
architectures it doesn't know about. (You can usually simulate them
by copying data). On some architectures there is _no_ alignment which
works, and even on x86 aligning aliases to 32k results in faster
memory accesses on some chips (AMD ones).
Also, sometimes a self wrapping ring buffer can work even when the
separation isn't coherent, provided the code using it forces cache
line flushes at the appropriate points.
-- Jamie
next prev parent reply other threads:[~2003-12-14 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-13 11:41 Possible shared mapping bug in 2.4.23 (at least MIPS/Sparc) Peter Horton
2003-12-13 16:05 ` Ralf Baechle
2003-12-13 18:08 ` Peter Horton
2003-12-13 22:26 ` Jamie Lokier
2003-12-14 1:41 ` Linus Torvalds
2003-12-14 4:20 ` Jamie Lokier
2003-12-14 10:38 ` Peter Horton
2003-12-14 17:16 ` Jamie Lokier [this message]
2003-12-25 13:03 ` Ralf Baechle
2003-12-14 18:05 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031214171637.GA28923@mail.shareable.org \
--to=jamie@shareable.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pdh@colonel-panic.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox