Re: PCI Express support for 2.4 kernel

Geert Uytterhoeven
2003-12-17T10:05:26Z

On Wed, 17 Dec 2003, Vladimir Kondratiev wrote:
> Greg KH wrote:
> >Minor code comments below:
> >On Tue, Dec 16, 2003 at 12:20:39PM +0200, Vladimir Kondratiev wrote:
> >>+ printk(KERN_INFO "PCI-Express config at 0x%08x\n", rrbar_phys);
> >>
> >>
> >
> >"%p" to show the address might be nicer.
> >
> I print phys. address, it is u32. Do you mean (void*)rrbar_phys? Don't
> see why not to change,
> I have no strong opinion for which format is better.

Are you 100% sure the physical address value will be limited to 32-bit on
64-bit platforms, too?

If not (and IMHO even if yes, for clarity), you should use long or void *,
which is 64-bit on 64-bit platforms.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds