public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Fedyk <mfedyk@matchmail.com>
To: "Ronny V. Vindenes" <s864@ii.uib.no>
Cc: linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
Date: Thu, 18 Dec 2003 11:21:32 -0800	[thread overview]
Message-ID: <20031218192132.GE6438@matchmail.com> (raw)
In-Reply-To: <m3llpannhf.fsf@terminal124.gozu.lan>

On Thu, Dec 18, 2003 at 04:40:12PM +0100, Ronny V. Vindenes wrote:
> Mike Fedyk <mfedyk@matchmail.com> writes:
> > +		K(nr_inactive_dirty_pages()) + K(nr_inactive_dirty_pages())
>                               ^^^^^  
> Shouldn't that be nr_inactive_clean_pages() ? now it's 2*dirty + laundry
> 

Yes, good catch.  Thanks

> > +			+ K(nr_inactive_laundry_pages()),

How's this?

--- proc_misc.c.orig	2003-12-16 17:03:45.000000000 -0800
+++ proc_misc.c	2003-12-16 17:04:28.000000000 -0800
@@ -189,6 +189,7 @@
 		"Active:       %8u kB\n"
 		"ActiveAnon:   %8u kB\n"
 		"ActiveCache:  %8u kB\n"
+		"Inactive:     %8u kB\n"
 		"Inact_dirty:  %8u kB\n"
 		"Inact_laundry:%8u kB\n"
 		"Inact_clean:  %8u kB\n"
@@ -208,6 +209,8 @@
 		K(nr_active_anon_pages()) + K(nr_active_cache_pages()),
 		K(nr_active_anon_pages()),
 		K(nr_active_cache_pages()),
+		K(nr_inactive_dirty_pages()) + K(nr_inactive_laundry_pages())
+			+ K(nr_inactive_clean_pages()),
 		K(nr_inactive_dirty_pages()),
 		K(nr_inactive_laundry_pages()),
 		K(nr_inactive_clean_pages()),

  reply	other threads:[~2003-12-18 19:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11HNp-oH-19@gated-at.bofh.it>
     [not found] ` <11I6J-UO-15@gated-at.bofh.it>
     [not found]   ` <13yZr-2nX-23@gated-at.bofh.it>
2003-12-18 15:40     ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo Ronny V. Vindenes
2003-12-18 19:21       ` Mike Fedyk [this message]
2003-12-18 19:53         ` Rik van Riel
2003-12-11 22:42 Rik van Riel
2003-12-11 23:05 ` Mike Fedyk
2003-12-17  1:12   ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: " Mike Fedyk
2003-12-17  3:59     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031218192132.GE6438@matchmail.com \
    --to=mfedyk@matchmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=s864@ii.uib.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox