Re: [RFC] 2.6.0 EDD enhancements

Christoph Hellwig
2003-12-28T20:09:08Z

On Fri, Dec 19, 2003 at 01:01:29PM -0600, Matt Domsch wrote:
> ChangeSet@1.1532.1.2, 2003-12-18 16:35:16-06:00, Matt_Domsch@dell.com
> EDD: enable symlinks to SCSI devices
>
> Symlinks from /sys/firmware/edd/int13_dev8x/disc to the appropriate
> SCSI discs were added a year ago, but disabled because the
> scsi_bus list contained non-'scsi_device's at that time, which
> could have lead to an improper pointer following. The SCSI
> mid-layer has rectified this, so this code can be re-enabled
> in edd.c once again.

As James already said you're poking far too deep into scsi internals.
In addition to his comment I'd suggest putting the symlink creating
into scsi_sysfs.c and exporting a procedural interface for the edd
code. That way it'll get updated automatically if we change something.