public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: John Hawkes <hawkes@babylon.engr.sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	mingo@elte.hu, johnstul@us.ibm.com
Subject: Re: [RFC][PATCH] 2.6.0-test11 sched_clock() broken for "drifty ITC"
Date: Sat, 20 Dec 2003 02:41:59 -0800	[thread overview]
Message-ID: <20031220024159.49145807.akpm@osdl.org> (raw)
In-Reply-To: <200312182044.hBIKiCLY5477429@babylon.engr.sgi.com>

John Hawkes <hawkes@babylon.engr.sgi.com> wrote:
>
> David Mosberger suggests raising this issue on LKML to encourage a search
>  for a more general solution to my ia64 problem.
> 
>  My specific problem is that the generic ia64 sched_clock() is broken for
>  "drifty ITC" (the per-CPU cycle counter clock) platforms, such as the SGI
>  sn.  sched_clock() currently uses its local CPU's ITC and therefore on
>  drifty platforms its values are not synchronized across the CPUs.  This
>  results (in part) in an invalid load_balance() is-the-cache-hot-or-not
>  calculation.

Requiring that sched_clock() be synchronised is difficult for some
platforms.  Clearly, it is better if we can relax that.

> However, David Mosberger rejected this patch, and he seeks instead some
> hypothetical more generic approach to "drifty timebase platforms".  One
> possible generic change would be to relax the semantics of sched_clock() to
> no longer expect that the values be synchronized across all CPUs.

Your patch to kernel/sched.c looks good: low overhead, simple, Ingo likes
it.

Could you please finalise it, cook up the ia64 and numaq implementations
and send it over?



  parent reply	other threads:[~2003-12-20 10:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-18 20:44 [RFC][PATCH] 2.6.0-test11 sched_clock() broken for "drifty ITC" John Hawkes
2003-12-18 22:37 ` john stultz
2003-12-20 10:41 ` Andrew Morton [this message]
2003-12-20 10:50 ` Ingo Molnar
2003-12-20 14:57   ` Nick Piggin
2003-12-20 15:05     ` Andrew Morton
2003-12-20 15:12       ` Nick Piggin
2003-12-20 16:36         ` Ingo Molnar
2003-12-20 21:41         ` Zwane Mwaikambo
2003-12-29 18:51 ` John Hawkes
2003-12-29 19:32   ` [Lse-tech] " Martin J. Bligh
2003-12-29 20:16   ` John Hawkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031220024159.49145807.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hawkes@babylon.engr.sgi.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox