From: Andrew Morton <akpm@osdl.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de, mbligh@us.ibm.com
Subject: Re: [PATCH] make try_to_free_pages walk zonelist
Date: Sat, 20 Dec 2003 17:00:42 -0800 [thread overview]
Message-ID: <20031220170042.3feb6aa7.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.55L.0312201928530.31547@imladris.surriel.com>
Rik van Riel <riel@surriel.com> wrote:
>
> In 2.6.0 both __alloc_pages() and the corresponding
> wakeup_kswapd()s walk all zones in the zone list,
> possibly spanning multiple nodes in a low numa factor
> system like AMD64.
>
> Also, if lower_zone_protection is set in /proc, then
> it may be possible that kswapd never cleans out data
> in zones further down the zonelist and try_to_free_pages
> needs to do that.
>
> However, in 2.6.0 try_to_free_pages() only frees pages
> in the pgdat the first zone in the zonelist belongs to.
>
> This is probably the wrong behaviour, since both the
> page allocator and the kswapd wakeup free things from
> all zones on the zonelist. The following patch makes
> try_to_free_pages() consistent with the allocator, by
> passing the zonelist as an argument and freeing pages
> from all zones in the list.
hm, OK, so this should be a no-op for non-NUMA setups.
Prior to merging such a change it would be nice to have confirmed
before-and-after testing on real NUMA hardware. Rather than saying "gee,
this should help", but never knowing how much it really did help.
Could you suggest a suitable worklaod for Andi and Martin to test sometime?
Meanwhile, I'll mmify it for a bit of soak testing, thanks.
next prev parent reply other threads:[~2003-12-21 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-21 0:37 [PATCH] make try_to_free_pages walk zonelist Rik van Riel
2003-12-21 1:00 ` Andrew Morton [this message]
2003-12-21 1:10 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031220170042.3feb6aa7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@us.ibm.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox