2.6.0 Ooops while accessing ejected floppy

2.6.0 Ooops while accessing ejected floppy

[Wiktor Wodecki]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

Hello,

I forgot to unmount my floppy before ejecting it. No problem here (it is
my fault after all) but the kernel gave me an Ooops.
Nothing bad really happend, and I could continue work. However, I
thought to give a note here.

Dec 21 14:50:38 kakerlak kernel: floppy0: disk absent or changed during
operation
Dec 21 14:50:38 kakerlak kernel: end_request: I/O error, dev fd0, sector
7
Dec 21 14:50:38 kakerlak kernel: lost page write due to I/O error on fd0 
Dec 21 14:50:38 kakerlak kernel: buffer layer error at fs/buffer.c:2827
Dec 21 14:50:38 kakerlak kernel: Call Trace:
Dec 21 14:50:38 kakerlak kernel: [<c0157412>] drop_buffers+0xc2/0xd0
Dec 21 14:50:38 kakerlak kernel: [<c0157467>]
try_to_free_buffers+0x47/0xd0
Dec 21 14:50:38 kakerlak kernel: [<c015557e>]
block_invalidatepage+0xae/0xe0
Dec 21 14:50:38 kakerlak kernel: [<c01404a7>]
do_invalidatepage+0x27/0x30
Dec 21 14:50:38 kakerlak kernel: [<c014052b>]
truncate_complete_page+0x7b/0x80
Dec 21 14:50:38 kakerlak kernel: [<c01406e0>]
truncate_inode_pages+0xf0/0x290
Dec 21 14:50:38 kakerlak kernel: [<c016aa47>] dispose_list+0x97/0xa0
Dec 21 14:50:38 kakerlak kernel: [<c016abaa>]
invalidate_inodes+0x9a/0xc0
Dec 21 14:50:38 kakerlak kernel: [<c0158949>]
generic_shutdown_super+0x79/0x190
Dec 21 14:50:38 kakerlak kernel: [<c01595ad>] kill_block_super+0x1d/0x50 
Dec 21 14:50:38 kakerlak kernel: [<c015878e>] deactivate_super+0x5e/0xc0
Dec 21 14:50:38 kakerlak kernel: [<c016dd3f>] sys_umount+0x3f/0x90
Dec 21 14:50:38 kakerlak kernel: [<c016dda7>] sys_oldumount+0x17/0x20
Dec 21 14:50:38 kakerlak kernel: [<c0109387>] syscall_call+0x7/0xb


-- 
Regards,

Wiktor Wodecki

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.0 Ooops while accessing ejected floppy

[Andrew Morton]

Wiktor Wodecki <wodecki@gmx.de> wrote:
>
> I forgot to unmount my floppy before ejecting it. No problem here (it is
>  my fault after all) but the kernel gave me an Ooops.
>  Nothing bad really happend, and I could continue work. However, I
>  thought to give a note here.
> 
>  Dec 21 14:50:38 kakerlak kernel: floppy0: disk absent or changed during
>  operation
>  Dec 21 14:50:38 kakerlak kernel: end_request: I/O error, dev fd0, sector
>  7
>  Dec 21 14:50:38 kakerlak kernel: lost page write due to I/O error on fd0 
>  Dec 21 14:50:38 kakerlak kernel: buffer layer error at fs/buffer.c:2827

It's a warning, not an oops.  The below should shut it up.




From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Suppress a buffer_error() warning which occurs when a page which previously
had an I/O error gets its buffers stripped.



 fs/buffer.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/buffer.c~buffer_error-suppression fs/buffer.c
--- 25/fs/buffer.c~buffer_error-suppression	2003-12-21 22:11:33.000000000 -0800
+++ 25-akpm/fs/buffer.c	2003-12-21 22:11:33.000000000 -0800
@@ -2820,7 +2820,7 @@ drop_buffers(struct page *page, struct b
 		bh = bh->b_this_page;
 	} while (bh != head);
 
-	if (!was_uptodate && PageUptodate(page))
+	if (!was_uptodate && PageUptodate(page) && !PageError(page))
 		buffer_error();
 
 	do {

_