public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Wiktor Wodecki <wodecki@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0 Ooops while accessing ejected floppy
Date: Mon, 22 Dec 2003 01:32:15 -0800	[thread overview]
Message-ID: <20031222013215.7dc0595e.akpm@osdl.org> (raw)
In-Reply-To: <20031221163947.GA897@gmx.de>

Wiktor Wodecki <wodecki@gmx.de> wrote:
>
> I forgot to unmount my floppy before ejecting it. No problem here (it is
>  my fault after all) but the kernel gave me an Ooops.
>  Nothing bad really happend, and I could continue work. However, I
>  thought to give a note here.
> 
>  Dec 21 14:50:38 kakerlak kernel: floppy0: disk absent or changed during
>  operation
>  Dec 21 14:50:38 kakerlak kernel: end_request: I/O error, dev fd0, sector
>  7
>  Dec 21 14:50:38 kakerlak kernel: lost page write due to I/O error on fd0 
>  Dec 21 14:50:38 kakerlak kernel: buffer layer error at fs/buffer.c:2827

It's a warning, not an oops.  The below should shut it up.




From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Suppress a buffer_error() warning which occurs when a page which previously
had an I/O error gets its buffers stripped.



 fs/buffer.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/buffer.c~buffer_error-suppression fs/buffer.c
--- 25/fs/buffer.c~buffer_error-suppression	2003-12-21 22:11:33.000000000 -0800
+++ 25-akpm/fs/buffer.c	2003-12-21 22:11:33.000000000 -0800
@@ -2820,7 +2820,7 @@ drop_buffers(struct page *page, struct b
 		bh = bh->b_this_page;
 	} while (bh != head);
 
-	if (!was_uptodate && PageUptodate(page))
+	if (!was_uptodate && PageUptodate(page) && !PageError(page))
 		buffer_error();
 
 	do {

_


      reply	other threads:[~2003-12-22  9:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-21 16:39 2.6.0 Ooops while accessing ejected floppy Wiktor Wodecki
2003-12-22  9:32 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031222013215.7dc0595e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wodecki@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox