From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org,
Manuel Estrada Sainz <ranty@debian.org>,
Patrick Mochel <mochel@osdl.org>
Subject: Re: [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems
Date: Mon, 22 Dec 2003 22:29:17 -0500 [thread overview]
Message-ID: <200312222229.17991.dtor_core@ameritech.net> (raw)
In-Reply-To: <20031222093759.GB30235@kroah.com>
On Monday 22 December 2003 04:37 am, Greg KH wrote:
> On Sun, Dec 21, 2003 at 01:37:39AM -0500, Dmitry Torokhov wrote:
> > Hi,
> >
> > It seems that implementation of the firmware loader is racy as it
> > relies on kobject hotplug handler. Unfortunately that handler runs
> > too early, before firmware class attributes controlling the loading
> > process, are created. This causes firmware loading fail at least half
> > of the times on my laptop.
>
> Um, why not have your script wait until the files are present? That
> will remove any race conditions you will have.
>
How long should the userspace wait? One second as Manuel suggested?
Indefinitely? Or should the firmware agent have some timeout? If userspace
uses a timeout how should it correlate with the timeout on the kernel side?
I am sorry but I have to disagree with you. Kernel should not call user
space until it has all infrastructure in place and is ready. Anything
else is just a sloppy practice.
Dmitry
next prev parent reply other threads:[~2003-12-23 3:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-21 6:37 [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems Dmitry Torokhov
2003-12-22 9:37 ` Greg KH
2003-12-22 23:42 ` Marcel Holtmann
2003-12-23 3:29 ` Dmitry Torokhov [this message]
2003-12-23 8:48 ` Marcel Holtmann
2003-12-27 5:29 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 Dmitry Torokhov
2003-12-27 5:29 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 1/2) Dmitry Torokhov
2003-12-27 5:30 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 2/2) Dmitry Torokhov
2003-12-31 21:31 ` Greg KH
2003-12-31 22:16 ` [2.6 PATCH/RFC] Firmware loader fixes - take 2 (patch 1/2) Manuel Estrada Sainz
2003-12-31 22:32 ` [2.6 PATCH/RFC] Firmware loader - fix races and resource dealloocation problems Manuel Estrada Sainz
2003-12-31 23:03 ` Greg KH
2003-12-22 23:05 ` Manuel Estrada Sainz
2003-12-22 23:22 ` Greg KH
2003-12-26 17:29 ` Manuel Estrada Sainz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312222229.17991.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox