* [PATCH] Another dm and bio problem with 2.6.0
@ 2003-12-22 17:42 Mark Haverkamp
2003-12-23 11:45 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Mark Haverkamp @ 2003-12-22 17:42 UTC (permalink / raw)
To: linux-kernel
This fixes a problem similar to the patch I submitted on 11/20
http://marc.theaimsgroup.com/?l=linux-kernel&m=106936439707962&w=2
In this case, though, the result is an:
"Incorrect number of segments after building list" message.
The macro __BVEC_START assumes a bi_idx of zero when the dm code can
submit a bio with a non-zero bi_idx.
The code has been tested on an 8 way / 8gb OSDL STP machine with a 197G
lvm volume running dbt2 test.
===== include/linux/bio.h 1.34 vs edited =====
--- 1.34/include/linux/bio.h Sun Sep 21 14:50:33 2003
+++ edited/include/linux/bio.h Wed Dec 17 07:17:53 2003
@@ -162,7 +162,7 @@
*/
#define __BVEC_END(bio) bio_iovec_idx((bio), (bio)->bi_vcnt - 1)
-#define __BVEC_START(bio) bio_iovec_idx((bio), 0)
+#define __BVEC_START(bio) bio_iovec_idx((bio), (bio)->bi_idx)
#define BIOVEC_PHYS_MERGEABLE(vec1, vec2) \
((bvec_to_phys((vec1)) + (vec1)->bv_len) == bvec_to_phys((vec2)))
#define BIOVEC_VIRT_MERGEABLE(vec1, vec2) \
--
Mark Haverkamp <markh@osdl.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Another dm and bio problem with 2.6.0
2003-12-22 17:42 [PATCH] Another dm and bio problem with 2.6.0 Mark Haverkamp
@ 2003-12-23 11:45 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2003-12-23 11:45 UTC (permalink / raw)
To: Mark Haverkamp; +Cc: linux-kernel
On Mon, Dec 22 2003, Mark Haverkamp wrote:
> This fixes a problem similar to the patch I submitted on 11/20
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=106936439707962&w=2
>
> In this case, though, the result is an:
>
> "Incorrect number of segments after building list" message.
>
> The macro __BVEC_START assumes a bi_idx of zero when the dm code can
> submit a bio with a non-zero bi_idx.
> The code has been tested on an 8 way / 8gb OSDL STP machine with a 197G
> lvm volume running dbt2 test.
>
> ===== include/linux/bio.h 1.34 vs edited =====
> --- 1.34/include/linux/bio.h Sun Sep 21 14:50:33 2003
> +++ edited/include/linux/bio.h Wed Dec 17 07:17:53 2003
> @@ -162,7 +162,7 @@
> */
>
> #define __BVEC_END(bio) bio_iovec_idx((bio), (bio)->bi_vcnt - 1)
> -#define __BVEC_START(bio) bio_iovec_idx((bio), 0)
> +#define __BVEC_START(bio) bio_iovec_idx((bio), (bio)->bi_idx)
> #define BIOVEC_PHYS_MERGEABLE(vec1, vec2) \
> ((bvec_to_phys((vec1)) + (vec1)->bv_len) == bvec_to_phys((vec2)))
> #define BIOVEC_VIRT_MERGEABLE(vec1, vec2) \
Must have been some nasty debugging, good job. The patch is correct.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-12-23 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-22 17:42 [PATCH] Another dm and bio problem with 2.6.0 Mark Haverkamp
2003-12-23 11:45 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox