From: Rusty Russell <rusty@rustcorp.com.au>
To: Christophe Saout <christophe@saout.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
clemens@endorphin.org, thornber@sistina.com
Subject: Re: [PATCH 2/2][RFC] Add dm-crypt target
Date: Tue, 23 Dec 2003 13:53:26 +1100 [thread overview]
Message-ID: <20031223135326.216883e5.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20031222215236.GB13103@leto.cs.pocnet.net>
On Mon, 22 Dec 2003 22:52:36 +0100
Christophe Saout <christophe@saout.de> wrote:
> Hi,
Hi Christophe!
One anal comment:
> +/*
> + * module hooks
> + */
> +module_init(dm_crypt_init)
> +module_exit(dm_crypt_exit)
Please use semicolons here. It's nicer C-looking, and it means we don't have
to do silly things in the macros.
Thanks,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
next prev parent reply other threads:[~2003-12-23 3:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 21:42 loop driver, device-mapper and crypto Christophe Saout
2003-12-22 21:49 ` [PATCH 1/2] Add dm-daemon Christophe Saout
2003-12-23 12:27 ` Christoph Hellwig
2003-12-23 15:10 ` Joe Thornber
2003-12-22 21:52 ` [PATCH 2/2][RFC] Add dm-crypt target Christophe Saout
2003-12-22 23:07 ` Jeff Garzik
2003-12-22 23:24 ` Mike Fedyk
2003-12-22 23:29 ` Jeff Garzik
2003-12-22 23:50 ` Mike Fedyk
2003-12-23 0:10 ` Christophe Saout
2003-12-23 2:53 ` Rusty Russell [this message]
2003-12-23 13:13 ` Christoph Hellwig
2003-12-23 13:36 ` Christophe Saout
2003-12-23 15:15 ` Joe Thornber
2003-12-23 15:31 ` Jeff Garzik
2003-12-23 15:43 ` Joe Thornber
2003-12-23 17:01 ` Christophe Saout
2003-12-23 17:15 ` Joe Thornber
2003-12-23 17:14 ` Jeff Garzik
2003-12-22 22:03 ` loop driver, device-mapper and crypto Andrew Morton
2003-12-23 11:14 ` Fruhwirth Clemens
[not found] <15G6g-4oz-17@gated-at.bofh.it>
[not found] ` <15Gg9-4H6-25@gated-at.bofh.it>
2003-12-22 22:29 ` [PATCH 2/2][RFC] Add dm-crypt target Andi Kleen
2003-12-23 15:11 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031223135326.216883e5.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=christophe@saout.de \
--cc=clemens@endorphin.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thornber@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox