From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-hotplug-devel@lists.sourceforge.net
Subject: [PATCH] add sysfs misc class [4/5]
Date: Tue, 23 Dec 2003 13:30:37 -0800 [thread overview]
Message-ID: <20031223213037.GE15700@kroah.com> (raw)
In-Reply-To: <20031223212929.GD15700@kroah.com>
Add sysfs misc class support, and fix bug where misc_init() was being
called to late in the boot process.
diff -Nru a/drivers/char/misc.c b/drivers/char/misc.c
--- a/drivers/char/misc.c Tue Dec 23 12:53:35 2003
+++ b/drivers/char/misc.c Tue Dec 23 12:53:35 2003
@@ -47,7 +47,7 @@
#include <linux/devfs_fs_kernel.h>
#include <linux/stat.h>
#include <linux/init.h>
-
+#include <linux/device.h>
#include <linux/tty.h>
#include <linux/kmod.h>
@@ -180,6 +180,15 @@
return err;
}
+/*
+ * TODO for 2.7:
+ * - add a struct class_device to struct miscdevice and make all usages of
+ * them dynamic.
+ */
+static struct class misc_class = {
+ .name = "misc",
+};
+
static struct file_operations misc_fops = {
.owner = THIS_MODULE,
.open = misc_open,
@@ -234,6 +243,8 @@
"misc/%s", misc->name);
}
+ simple_add_class_device(&misc_class, MKDEV(MISC_MAJOR, misc->minor),
+ misc->dev, misc->name);
devfs_mk_cdev(MKDEV(MISC_MAJOR, misc->minor),
S_IFCHR|S_IRUSR|S_IWUSR|S_IRGRP, misc->devfs_name);
@@ -265,6 +276,7 @@
down(&misc_sem);
list_del(&misc->list);
+ simple_remove_class_device(MKDEV(MISC_MAJOR, misc->minor));
devfs_remove(misc->devfs_name);
if (i < DYNAMIC_MINORS && i>0) {
misc_minors[i>>3] &= ~(1 << (misc->minor & 7));
@@ -285,6 +297,7 @@
if (ent)
ent->proc_fops = &misc_proc_fops;
#endif
+ class_register(&misc_class);
#ifdef CONFIG_MVME16x
rtc_MK48T08_init();
#endif
@@ -319,4 +332,4 @@
}
return 0;
}
-module_init(misc_init);
+subsys_initcall(misc_init);
diff -Nru a/include/linux/miscdevice.h b/include/linux/miscdevice.h
--- a/include/linux/miscdevice.h Tue Dec 23 12:53:25 2003
+++ b/include/linux/miscdevice.h Tue Dec 23 12:53:25 2003
@@ -36,12 +36,15 @@
#define TUN_MINOR 200
+struct device;
+
struct miscdevice
{
int minor;
const char *name;
struct file_operations *fops;
struct list_head list;
+ struct device *dev;
char devfs_name[64];
};
next prev parent reply other threads:[~2003-12-23 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-23 21:24 [PATCH] sysfs class patches - take 2 [0/5] Greg KH
2003-12-23 21:26 ` [PATCH] add "simple" class device support [1/5] Greg KH
2003-12-23 21:27 ` [PATCH] remove tty class device logic [2/5] Greg KH
2003-12-23 21:29 ` [PATCH] add sysfs mem class [3/5] Greg KH
2003-12-23 21:30 ` Greg KH [this message]
2003-12-23 21:31 ` [PATCH] add sysfs vc class [5/5] Greg KH
2003-12-23 21:57 ` [PATCH] sysfs class patches - take 2 [0/5] Jeff Garzik
2003-12-23 22:07 ` Greg KH
2003-12-23 23:01 ` [PATCH] add video sysfs class [6/5] Greg KH
2003-12-24 14:27 ` [PATCH] sysfs class patches - take 2 [0/5] Kronos
2003-12-24 16:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031223213037.GE15700@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox