From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263762AbTLXSaQ (ORCPT ); Wed, 24 Dec 2003 13:30:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263769AbTLXSaP (ORCPT ); Wed, 24 Dec 2003 13:30:15 -0500 Received: from fw.osdl.org ([65.172.181.6]:22977 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S263762AbTLXSaM (ORCPT ); Wed, 24 Dec 2003 13:30:12 -0500 Date: Wed, 24 Dec 2003 10:30:16 -0800 From: Andrew Morton To: Greg KH Cc: raven@themaw.net, torvalds@osdl.org, ULMO@Q.NET, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clean up fs/devfs/base.c Message-Id: <20031224103016.37cf5ea3.akpm@osdl.org> In-Reply-To: <20031224171054.GB29796@kroah.com> References: <20031224034110.GA25709@kroah.com> <20031224171054.GB29796@kroah.com> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Greg KH wrote: > > On Wed, Dec 24, 2003 at 12:00:13PM +0800, Ian Kent wrote: > > On Tue, 23 Dec 2003, Greg KH wrote: > > > > > On Tue, Dec 23, 2003 at 06:38:20PM -0800, Andrew Morton wrote: > > > > > > > > Now would be a good time for someone to feed the whole thing through indent > > > > though. > > > > > > As much as I enjoy using the devfs code as my "bad coding style" > > > example, here's a patch against 2.6.0 that cleans up the devfs code to > > > follow the proper kernel coding style. > > > > I think it needs a little bit more than that Greg. > > Oh, I know it does. That was just a "convert to proper coding format in > 15 minutes" patch. You should start with that and work from there. > But, if you are going to do this, remember to submit in incremental > changes. I suggest this patch go in, as it is just a reformatting, > nothing else. Then you can work from there, changing the actual logic > of the code. Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate.