From: Greg KH <greg@kroah.com>
To: Ian Kent <raven@themaw.net>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
ULMO@Q.NET, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clean up fs/devfs/base.c
Date: Wed, 24 Dec 2003 09:10:54 -0800 [thread overview]
Message-ID: <20031224171054.GB29796@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0312241155170.3667-100000@wombat.indigo.net.au>
On Wed, Dec 24, 2003 at 12:00:13PM +0800, Ian Kent wrote:
> On Tue, 23 Dec 2003, Greg KH wrote:
>
> > On Tue, Dec 23, 2003 at 06:38:20PM -0800, Andrew Morton wrote:
> > >
> > > Now would be a good time for someone to feed the whole thing through indent
> > > though.
> >
> > As much as I enjoy using the devfs code as my "bad coding style"
> > example, here's a patch against 2.6.0 that cleans up the devfs code to
> > follow the proper kernel coding style.
>
> I think it needs a little bit more than that Greg.
Oh, I know it does. That was just a "convert to proper coding format in
15 minutes" patch. You should start with that and work from there.
But, if you are going to do this, remember to submit in incremental
changes. I suggest this patch go in, as it is just a reformatting,
nothing else. Then you can work from there, changing the actual logic
of the code.
thanks,
greg k-h
next prev parent reply other threads:[~2003-12-24 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031224034110.GA25709@kroah.com>
2003-12-24 4:00 ` [PATCH] clean up fs/devfs/base.c Ian Kent
2003-12-24 17:10 ` Greg KH [this message]
2003-12-24 18:30 ` Andrew Morton
2003-12-25 4:07 ` Ian Kent
2003-12-26 3:12 ` Ian Kent
2003-12-27 11:19 ` Ian Kent
2003-12-25 3:51 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031224171054.GB29796@kroah.com \
--to=greg@kroah.com \
--cc=ULMO@Q.NET \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox