From: Jeff Garzik <jgarzik@pobox.com>
To: "Zhu, Yi" <yi.zhu@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix make kernel rpm bug
Date: Wed, 24 Dec 2003 23:12:18 -0500 [thread overview]
Message-ID: <20031225041218.GA7533@gtf.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0312251035320.16217-100000@mazda.sh.intel.com>
On Thu, Dec 25, 2003 at 10:43:52AM +0800, Zhu, Yi wrote:
> Hi Andrew,
>
> Below two lines patch makes the rpm rule in top Makefile be aware of
> $(ARCH). The old rule will make wrong rpm if ARCH is not the same as
> the build machine.
>
>
> diff -Nru a/Makefile b/Makefile
> --- a/Makefile Wed Dec 10 13:47:52 2003
> +++ b/Makefile Wed Dec 10 13:47:52 2003
> @@ -872,7 +872,7 @@
> $(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version;\
> mv -f $(objtree)/.tmp_version $(objtree)/.version;
>
> - $(RPM) -ta ../$(KERNELPATH).tar.gz
> + $(RPM) --target $(ARCH) -ta ../$(KERNELPATH).tar.gz
> rm ../$(KERNELPATH).tar.gz
>
> # Brief documentation of the typical targets used
> diff -Nru a/scripts/mkspec b/scripts/mkspec
> --- a/scripts/mkspec Wed Dec 10 13:47:52 2003
> +++ b/scripts/mkspec Wed Dec 10 13:47:52 2003
> @@ -9,7 +9,7 @@
> # Patched for non-x86 by Opencon (L) 2002 <opencon@rio.skydome.net>
> #
> # That's the voodoo to see if it's a x86.
> -ISX86=`arch | grep -ie i.86`
> +ISX86=`echo ${ARCH:=\`arch\`} | grep -ie i.86`
hmmm, I don't think $(ARCH) makes the rpm --target strings in all
cases..
Jeff
next prev parent reply other threads:[~2003-12-25 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-10 9:06 Make rpm patch for cross compile 2.6.0-test11 Zhu, Yi
2003-12-25 2:43 ` [PATCH] fix make kernel rpm bug Zhu, Yi
2003-12-25 4:12 ` Jeff Garzik [this message]
2003-12-29 3:19 ` [PATCH] fix make kernel rpm bug (revised) Zhu, Yi
[not found] <3ACA40606221794F80A5670F0AF15F840254C76E@PDSMSX403.ccr.corp.intel.com>
2003-12-25 6:58 ` [PATCH] fix make kernel rpm bug Zhu, Yi
2003-12-25 9:49 ` Russell King
[not found] <3ACA40606221794F80A5670F0AF15F840254C793@PDSMSX403.ccr.corp.intel.com>
2003-12-26 7:26 ` Zhu, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031225041218.GA7533@gtf.org \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox