public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.6] fix yenta memleak
@ 2003-12-28 17:52 Daniel Ritz
  2003-12-28 19:55 ` Russell King
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ritz @ 2003-12-28 17:52 UTC (permalink / raw)
  To: Russell King, linux-pcmcia, linux-kernel

fix a memleak on yenta_socket unload.
against 2.6.0


--- 1.50/drivers/pcmcia/yenta_socket.c	Tue Oct 28 00:12:06 2003
+++ edited/drivers/pcmcia/yenta_socket.c	Sun Dec 28 18:35:30 2003
@@ -648,6 +648,8 @@
 
 	pci_release_regions(dev);
 	pci_set_drvdata(dev, NULL);
+
+	kfree(sock);
 }
 
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6] fix yenta memleak
  2003-12-28 17:52 [PATCH 2.6] fix yenta memleak Daniel Ritz
@ 2003-12-28 19:55 ` Russell King
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2003-12-28 19:55 UTC (permalink / raw)
  To: Daniel Ritz; +Cc: linux-pcmcia, linux-kernel

On Sun, Dec 28, 2003 at 06:52:14PM +0100, Daniel Ritz wrote:
> fix a memleak on yenta_socket unload.
> against 2.6.0

This looks fine; we don't allow the unload to continue until we've
made sure that sysfs has finished using sock, which prevents us
kfree'ing it while it's still in use.

I'll add this to the outgoing queue of pcmcia patches.  Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-12-28 19:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-28 17:52 [PATCH 2.6] fix yenta memleak Daniel Ritz
2003-12-28 19:55 ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox