From: Christoph Hellwig <hch@infradead.org>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [RFC] 2.6.0 EDD enhancements
Date: Sun, 28 Dec 2003 20:08:54 +0000 [thread overview]
Message-ID: <20031228200854.B22668@infradead.org> (raw)
In-Reply-To: <20031219130129.B6530@lists.us.dell.com>; from Matt_Domsch@dell.com on Fri, Dec 19, 2003 at 01:01:29PM -0600
On Fri, Dec 19, 2003 at 01:01:29PM -0600, Matt Domsch wrote:
> ChangeSet@1.1532.1.2, 2003-12-18 16:35:16-06:00, Matt_Domsch@dell.com
> EDD: enable symlinks to SCSI devices
>
> Symlinks from /sys/firmware/edd/int13_dev8x/disc to the appropriate
> SCSI discs were added a year ago, but disabled because the
> scsi_bus list contained non-'scsi_device's at that time, which
> could have lead to an improper pointer following. The SCSI
> mid-layer has rectified this, so this code can be re-enabled
> in edd.c once again.
As James already said you're poking far too deep into scsi internals.
In addition to his comment I'd suggest putting the symlink creating
into scsi_sysfs.c and exporting a procedural interface for the edd
code. That way it'll get updated automatically if we change something.
next prev parent reply other threads:[~2003-12-28 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 18:57 [RFC] 2.6.0 EDD enhancements Matt Domsch
2003-12-19 19:01 ` Matt Domsch
2003-12-19 19:01 ` Matt Domsch
2003-12-19 20:23 ` James Bottomley
2003-12-19 20:37 ` Matt Domsch
2003-12-19 21:03 ` James Bottomley
2003-12-28 20:08 ` Christoph Hellwig [this message]
2003-12-29 20:05 ` Matt Domsch
2003-12-19 19:01 ` Matt Domsch
2003-12-19 19:03 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031228200854.B22668@infradead.org \
--to=hch@infradead.org \
--cc=Matt_Domsch@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox