From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265384AbTL2UK2 (ORCPT ); Mon, 29 Dec 2003 15:10:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265385AbTL2UIQ (ORCPT ); Mon, 29 Dec 2003 15:08:16 -0500 Received: from linux.us.dell.com ([143.166.224.162]:11947 "EHLO lists.us.dell.com") by vger.kernel.org with ESMTP id S265060AbTL2UGT (ORCPT ); Mon, 29 Dec 2003 15:06:19 -0500 Date: Mon, 29 Dec 2003 14:05:41 -0600 From: Matt Domsch To: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [RFC] 2.6.0 EDD enhancements Message-ID: <20031229140541.A31985@lists.us.dell.com> References: <20031219130129.B6530@lists.us.dell.com> <20031228200854.B22668@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20031228200854.B22668@infradead.org>; from hch@infradead.org on Sun, Dec 28, 2003 at 08:08:54PM +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > As James already said you're poking far too deep into scsi internals. > In addition to his comment I'd suggest putting the symlink creating > into scsi_sysfs.c and exporting a procedural interface for the edd > code. That way it'll get updated automatically if we change something. Thanks for the feedback. I'll rework it to move to scsi_sysfs.c (and for the similar IDE and pci_dev pieces likewise). Thanks, Matt -- Matt Domsch Sr. Software Engineer, Lead Engineer Dell Linux Solutions www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com