From: Muli Ben-Yehuda <mulix@mulix.org>
To: "Sirotkin, Alexander" <demiurg@ti.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: network driver that uses skb destructor
Date: Mon, 29 Dec 2003 19:24:02 +0200 [thread overview]
Message-ID: <20031229172402.GG13481@actcom.co.il> (raw)
In-Reply-To: <3FF05C27.5030706@ti.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Mon, Dec 29, 2003 at 06:53:59PM +0200, Sirotkin, Alexander wrote:
> Anybody tried to implement similar approach ?
> Any thoughts why this would (or would not) work ?
It's a nice idea in theory, but the reality is that as the code
currently stands, the upper layers 'hijack' the skb->destructor
without regards to whether it was set previously, causing your memory
to leak. See skb_set_owner_w(), skb_set_owner_r().
I wrote a patch to allow chaining of skb destructors, which was fairly
simple and would allow both the driver and the upper layers to set
their destructors. If there's any interet, I could probably resurrect
it.
Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
"the nucleus of linux oscillates my world" - gccbot@#offtopic
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-12-29 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-29 16:53 network driver that uses skb destructor Sirotkin, Alexander
2003-12-29 17:24 ` Muli Ben-Yehuda [this message]
2003-12-30 9:13 ` Adrian Cox
2003-12-30 9:36 ` Muli Ben-Yehuda
2004-01-01 19:09 ` [RFC/PATCH] skb destructor chaining [was Re: network driver that uses skb destructor] Muli Ben-Yehuda
2003-12-30 9:48 ` network driver that uses skb destructor Duncan Sands
2003-12-30 15:02 ` [Linux-ATM-General] " chas williams
2003-12-29 19:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031229172402.GG13481@actcom.co.il \
--to=mulix@mulix.org \
--cc=demiurg@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox